Skip to content

Commit 8fab099

Browse files
committed
make : put preprocessor stuff in CPPFLAGS
1 parent dca3c06 commit 8fab099

File tree

1 file changed

+24
-27
lines changed

1 file changed

+24
-27
lines changed

Makefile

Lines changed: 24 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -67,21 +67,21 @@ OPT = -Ofast
6767
else
6868
OPT = -O3
6969
endif
70-
CFLAGS = -I. $(OPT) -std=c11 -fPIC
71-
CXXFLAGS = -I. -I./common $(OPT) -std=c++11 -fPIC
70+
CPPFLAGS = -I. -Icommon
71+
CFLAGS = $(CPPFLAGS) $(OPT) -std=c11 -fPIC
72+
CXXFLAGS = $(CPPFLAGS) $(OPT) -std=c++11 -fPIC
7273
LDFLAGS =
7374

7475
ifdef LLAMA_DEBUG
7576
CFLAGS += -O0 -g
7677
CXXFLAGS += -O0 -g
7778
LDFLAGS += -g
7879
else
79-
CFLAGS += -DNDEBUG
80-
CXXFLAGS += -DNDEBUG
80+
CPPFLAGS += -DNDEBUG
8181
endif
8282

8383
ifdef LLAMA_SERVER_VERBOSE
84-
CXXFLAGS += -DSERVER_VERBOSE=$(LLAMA_SERVER_VERBOSE)
84+
CPPFLAGS += -DSERVER_VERBOSE=$(LLAMA_SERVER_VERBOSE)
8585
endif
8686

8787
ifdef LLAMA_DISABLE_LOGS
@@ -153,8 +153,7 @@ ifdef LLAMA_GPROF
153153
CXXFLAGS += -pg
154154
endif
155155
ifdef LLAMA_PERF
156-
CFLAGS += -DGGML_PERF
157-
CXXFLAGS += -DGGML_PERF
156+
CPPFLAGS += -DGGML_PERF
158157
endif
159158

160159
# Architecture specific
@@ -221,43 +220,42 @@ else
221220
endif
222221

223222
ifndef LLAMA_NO_K_QUANTS
224-
CFLAGS += -DGGML_USE_K_QUANTS
225-
CXXFLAGS += -DGGML_USE_K_QUANTS
223+
CPPFLAGS += -DGGML_USE_K_QUANTS
226224
OBJS += k_quants.o
227225
ifdef LLAMA_QKK_64
228-
CFLAGS += -DGGML_QKK_64
229-
CXXFLAGS += -DGGML_QKK_64
226+
CPPFLAGS += -DGGML_QKK_64
230227
endif
231228
endif
232229

233230
ifndef LLAMA_NO_ACCELERATE
234231
# Mac M1 - include Accelerate framework.
235232
# `-framework Accelerate` works on Mac Intel as well, with negliable performance boost (as of the predict time).
236233
ifeq ($(UNAME_S),Darwin)
237-
CFLAGS += -DGGML_USE_ACCELERATE
238-
LDFLAGS += -framework Accelerate
234+
CPPFLAGS += -DGGML_USE_ACCELERATE
235+
LDFLAGS += -framework Accelerate
239236
endif
240237
endif # LLAMA_NO_ACCELERATE
241238

242239
ifdef LLAMA_MPI
243-
CFLAGS += -DGGML_USE_MPI -Wno-cast-qual
244-
CXXFLAGS += -DGGML_USE_MPI -Wno-cast-qual
240+
CPPFLAGS += -DGGML_USE_MPI
241+
CFLAGS += -Wno-cast-qual
242+
CXXFLAGS += -Wno-cast-qual
245243
OBJS += ggml-mpi.o
246244
endif # LLAMA_MPI
247245

248246
ifdef LLAMA_OPENBLAS
249-
CFLAGS += -DGGML_USE_OPENBLAS $(shell pkg-config --cflags openblas)
250-
LDFLAGS += $(shell pkg-config --libs openblas)
247+
CPPFLAGS += -DGGML_USE_OPENBLAS $(shell pkg-config --cflags-only-I openblas)
248+
CFLAGS += $(shell pkg-config --cflags-only-other openblas)
249+
LDFLAGS += $(shell pkg-config --libs openblas)
251250
endif # LLAMA_OPENBLAS
252251

253252
ifdef LLAMA_BLIS
254-
CFLAGS += -DGGML_USE_OPENBLAS -I/usr/local/include/blis -I/usr/include/blis
255-
LDFLAGS += -lblis -L/usr/local/lib
253+
CPPFLAGS += -DGGML_USE_OPENBLAS -I/usr/local/include/blis -I/usr/include/blis
254+
LDFLAGS += -lblis -L/usr/local/lib
256255
endif # LLAMA_BLIS
257256

258257
ifdef LLAMA_CUBLAS
259-
CFLAGS += -DGGML_USE_CUBLAS -I/usr/local/cuda/include -I/opt/cuda/include -I$(CUDA_PATH)/targets/x86_64-linux/include
260-
CXXFLAGS += -DGGML_USE_CUBLAS -I/usr/local/cuda/include -I/opt/cuda/include -I$(CUDA_PATH)/targets/x86_64-linux/include
258+
CPPFLAGS += -DGGML_USE_CUBLAS -I/usr/local/cuda/include -I/opt/cuda/include -I$(CUDA_PATH)/targets/x86_64-linux/include
261259
LDFLAGS += -lcublas -lculibos -lcudart -lcublasLt -lpthread -ldl -lrt -L/usr/local/cuda/lib64 -L/opt/cuda/lib64 -L$(CUDA_PATH)/targets/x86_64-linux/lib
262260
OBJS += ggml-cuda.o
263261
NVCCFLAGS = --forward-unknown-to-host-compiler -use_fast_math
@@ -309,8 +307,9 @@ endif # LLAMA_CUBLAS
309307

310308
ifdef LLAMA_CLBLAST
311309

312-
CFLAGS += -DGGML_USE_CLBLAST $(shell pkg-config --cflags clblast OpenCL)
313-
CXXFLAGS += -DGGML_USE_CLBLAST $(shell pkg-config --cflags clblast OpenCL)
310+
CPPFLAGS += -DGGML_USE_CLBLAST $(shell pkg-config --cflags-only-I clblast OpenCL)
311+
CFLAGS += $(shell pkg-config --cflags-only-other clblast OpenCL)
312+
CXXFLAGS += $(shell pkg-config --cflags-only-other clblast OpenCL)
314313

315314
# Mac provides OpenCL as a framework
316315
ifeq ($(UNAME_S),Darwin)
@@ -331,8 +330,7 @@ ifdef LLAMA_HIPBLAS
331330
LLAMA_CUDA_DMMV_X ?= 32
332331
LLAMA_CUDA_MMV_Y ?= 1
333332
LLAMA_CUDA_KQUANTS_ITER ?= 2
334-
CFLAGS += -DGGML_USE_HIPBLAS -DGGML_USE_CUBLAS
335-
CXXFLAGS += -DGGML_USE_HIPBLAS -DGGML_USE_CUBLAS
333+
CPPFLAGS += -DGGML_USE_HIPBLAS -DGGML_USE_CUBLAS
336334
LDFLAGS += -L$(ROCM_PATH)/lib -Wl,-rpath=$(ROCM_PATH)/lib
337335
LDFLAGS += -lhipblas -lamdhip64 -lrocblas
338336
HIPFLAGS += $(addprefix --offload-arch=,$(GPU_TARGETS))
@@ -349,8 +347,7 @@ ggml-cuda.o: ggml-cuda.cu ggml-cuda.h
349347
endif # LLAMA_HIPBLAS
350348

351349
ifdef LLAMA_METAL
352-
CFLAGS += -DGGML_USE_METAL #-DGGML_METAL_NDEBUG
353-
CXXFLAGS += -DGGML_USE_METAL
350+
CPPFLAGS += -DGGML_USE_METAL #-DGGML_METAL_NDEBUG
354351
LDFLAGS += -framework Foundation -framework Metal -framework MetalKit
355352
OBJS += ggml-metal.o
356353
endif # LLAMA_METAL

0 commit comments

Comments
 (0)