Skip to content

Commit 9e2d2d9

Browse files
mofosynecompilade
andauthored
Apply suggestions from code review
Co-authored-by: compilade <[email protected]>
1 parent d460f74 commit 9e2d2d9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

gguf-py/scripts/gguf-dump.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ def dump_markdown_metadata(reader: GGUFReader, args: argparse.Namespace) -> None
228228
markdown_content += f'# {args.model} - GGUF Internal File Dump\n'
229229
markdown_content += f'* Endian: {file_endian} endian\n'
230230
markdown_content += '\n'
231-
markdown_content += '## Key Value Metadata Store\n'
231+
markdown_content += '## Key Value Metadata Store\n\n'
232232
markdown_content += f'There is {len(reader.fields)} key/value pair(s) in this file\n'
233233
markdown_content += '\n'
234234

@@ -265,9 +265,9 @@ def dump_markdown_metadata(reader: GGUFReader, args: argparse.Namespace) -> None
265265
kv_dump_table.append({"n":n, "pretty_type":pretty_type, "total_elements":total_elements, "field_name":field.name, "value":value})
266266

267267
kv_dump_table_header_map = [
268-
{'key_name':'n', 'header_name':'POS', 'align':'center'},
268+
{'key_name':'n', 'header_name':'POS', 'align':'right'},
269269
{'key_name':'pretty_type', 'header_name':'TYPE', 'align':'left'},
270-
{'key_name':'total_elements', 'header_name':'Count', 'align':'left'},
270+
{'key_name':'total_elements', 'header_name':'Count', 'align':'right'},
271271
{'key_name':'field_name', 'header_name':'Key', 'align':'left'},
272272
{'key_name':'value', 'header_name':'Value', 'align':'left'},
273273
]
@@ -302,7 +302,7 @@ def dump_markdown_metadata(reader: GGUFReader, args: argparse.Namespace) -> None
302302
tensor_name_to_key[tensor.name] = key
303303

304304
# Tensors Mapping Dump
305-
markdown_content += f'## Tensors Overview {element_count_rounded_notation(total_elements)} Elements\n'
305+
markdown_content += f'## Tensors Overview {element_count_rounded_notation(total_elements)} Elements\n\n'
306306
markdown_content += f'Total number of elements in all tensors: {total_elements} Elements\n'
307307
markdown_content += '\n'
308308

@@ -317,7 +317,7 @@ def dump_markdown_metadata(reader: GGUFReader, args: argparse.Namespace) -> None
317317
tensors = tensor_groups[group]
318318
group_elements = sum(tensor.n_elements for tensor in tensors)
319319
group_percentage = group_elements / total_elements * 100
320-
markdown_content += f"### <a name=\"{group.replace('.', '_')}\">{translate_tensor_name(group)} Tensor Group : {element_count_rounded_notation(group_elements)} Elements</a>\n"
320+
markdown_content += f"### <a name=\"{group.replace('.', '_')}\">{translate_tensor_name(group)} Tensor Group : {element_count_rounded_notation(group_elements)} Elements</a>\n\n"
321321

322322
tensor_dump_table = []
323323
for tensor in tensors:
@@ -328,7 +328,7 @@ def dump_markdown_metadata(reader: GGUFReader, args: argparse.Namespace) -> None
328328
tensor_dump_table.append({"t_id":tensor_name_to_key[tensor.name], "layer_name":tensor.name, "human_layer_name":human_friendly_name, "element_count":element_count_string, "pretty_dims":prettydims, "tensor_type":type_name_string})
329329

330330
tensor_dump_table_header_map = [
331-
{'key_name':'t_id', 'header_name':'T_ID', 'align':'center'},
331+
{'key_name':'t_id', 'header_name':'T_ID', 'align':'right'},
332332
{'key_name':'layer_name', 'header_name':'Tensor Layer Name', 'align':'left'},
333333
{'key_name':'human_layer_name', 'header_name':'Human Friendly Tensor Layer Name', 'align':'left'},
334334
{'key_name':'element_count', 'header_name':'Elements', 'align':'left'},

0 commit comments

Comments
 (0)