Skip to content

Commit 9e39571

Browse files
committed
add n_batch for pca
1 parent 6a5adf3 commit 9e39571

File tree

2 files changed

+184
-118
lines changed

2 files changed

+184
-118
lines changed

examples/control-vector-generator/control-vector-generator.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,9 @@ struct train_context {
188188
for (int il = 0; il < n_layers - 1; il++) {
189189
std::vector<uint8_t> empty;
190190
v_diff_tmp.push_back(empty);
191-
v_final.push_back(ggml_new_tensor_1d(ctx_ggml, GGML_TYPE_F32, n_embd));
191+
auto t = ggml_new_tensor_1d(ctx_ggml, GGML_TYPE_F32, n_embd);
192+
t->data = malloc(ggml_nbytes(t)); // TODO: get rid of malloc if possible
193+
v_final.push_back(t);
192194
}
193195
}
194196

@@ -625,7 +627,9 @@ int main(int argc, char ** argv) {
625627
ctx_train.build_v_diff();
626628

627629
// run PCA
628-
PCA::run_pca(ctx_train.v_diff, ctx_train.v_final);
630+
PCA::pca_params pca_params;
631+
PCA::run_pca(pca_params, ctx_train.v_diff, ctx_train.v_final);
632+
exit(0); // TODO: REMOVE ME !!!!!!!!!!!!!!!!!!!!!!!!
629633

630634
// write output vectors to gguf
631635
export_gguf(ctx_train.v_final, cparams.outfile, model_hint);

0 commit comments

Comments
 (0)