Skip to content

Commit b14b9bf

Browse files
committed
amx : minor opt
ggml-ci
1 parent 8bfef91 commit b14b9bf

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

ggml/src/ggml-cpu/amx/common.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ inline void parallel_for_ggml(const ggml_compute_params * params, int n, const f
7878
int tbegin, tend;
7979
balance211(n, params->nth, params->ith, tbegin, tend);
8080
f(tbegin, tend);
81-
ggml_barrier(params->threadpool); // TODO: might not always be needed
8281
}
8382

8483
// quantized types that have AMX support

ggml/src/ggml-cpu/amx/mmq.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,10 +1349,10 @@ struct tinygemm_kernel_avx<float, ggml_fp16_t, float, BLOCK_M, BLOCK_N, BLOCK_K>
13491349
constexpr int row = idx / COLS;
13501350
constexpr int col = idx % COLS;
13511351

1352-
if (col == 0) {
1352+
if constexpr (col == 0) {
13531353
va = _mm512_loadu_ps(A + row * K + k);
13541354
}
1355-
if (row == 0) {
1355+
if constexpr (row == 0) {
13561356
vb[col] = _mm512_cvtph_ps(_mm256_loadu_si256((const __m256i *)(B + col * K + k)));
13571357
}
13581358
vc[idx] = _mm512_fmadd_ps(va, vb[col], vc[idx]);

0 commit comments

Comments
 (0)