Skip to content

Commit b88fe16

Browse files
Clarify feature layers are non negative ints and not uint
Signed-off-by: Alex-Brooks <[email protected]>
1 parent ba0ef5d commit b88fe16

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

examples/llava/clip.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1488,8 +1488,8 @@ struct clip_ctx * clip_model_load(const char * fname, const int verbosity = 1) {
14881488
// Load the vision feature layer indices if they are explicitly provided;
14891489
// if multiple vision feature layers are present, the values will be concatenated
14901490
// to form the final visual features.
1491-
// NOTE: gguf conversions should standardize the values of the vision feature layer to uints,
1492-
// since we use -1 as an unset value here.
1491+
// NOTE: gguf conversions should standardize the values of the vision feature layer to
1492+
// be non-negative, since we use -1 to mark values as unset here.
14931493
try {
14941494
int idx = get_key_idx(ctx, KEY_FEATURE_LAYER);
14951495
int n = gguf_get_arr_n(ctx, idx);

0 commit comments

Comments
 (0)