Skip to content

Commit cfef355

Browse files
committed
fix some inconsistencies in the names of functions
1 parent d0c4954 commit cfef355

File tree

3 files changed

+69
-69
lines changed

3 files changed

+69
-69
lines changed

ggml/src/ggml-backend-impl.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,10 @@ extern "C" {
170170
ggml_backend_t (*init_backend)(ggml_backend_dev_t dev, const char * params);
171171

172172
// preferred buffer type
173-
ggml_backend_buffer_type_t (*buffer_type)(ggml_backend_dev_t dev);
173+
ggml_backend_buffer_type_t (*get_buffer_type)(ggml_backend_dev_t dev);
174174

175175
// (optional) host buffer type (in system memory, typically this is a pinned memory buffer for faster transfers between host and device)
176-
ggml_backend_buffer_type_t (*host_buffer_type)(ggml_backend_dev_t dev);
176+
ggml_backend_buffer_type_t (*get_host_buffer_type)(ggml_backend_dev_t dev);
177177

178178
// (optional) buffer from pointer: create a buffer from a host pointer (useful for memory mapped models and importing data from other libraries)
179179
ggml_backend_buffer_t (*buffer_from_host_ptr)(ggml_backend_dev_t dev, void * ptr, size_t size, size_t max_tensor_size);
@@ -209,8 +209,8 @@ extern "C" {
209209
const char * (*get_name)(ggml_backend_reg_t reg);
210210

211211
// enumerate available devices
212-
size_t (*device_count)(ggml_backend_reg_t reg);
213-
ggml_backend_dev_t (*device_get)(ggml_backend_reg_t reg, size_t index);
212+
size_t (*get_device_count)(ggml_backend_reg_t reg);
213+
ggml_backend_dev_t (*get_device)(ggml_backend_reg_t reg, size_t index);
214214

215215
// (optional) get a pointer to a function in the backend
216216
// backends can add custom functions that are not part of the standard ggml-backend interface

ggml/src/ggml-backend.cpp

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -461,11 +461,11 @@ ggml_backend_t ggml_backend_dev_init(ggml_backend_dev_t device, const char * par
461461
}
462462

463463
ggml_backend_buffer_type_t ggml_backend_dev_buffer_type(ggml_backend_dev_t device) {
464-
return device->iface.buffer_type(device);
464+
return device->iface.get_buffer_type(device);
465465
}
466466

467467
ggml_backend_buffer_type_t ggml_backend_dev_host_buffer_type(ggml_backend_dev_t device) {
468-
return device->iface.host_buffer_type(device);
468+
return device->iface.get_host_buffer_type(device);
469469
}
470470

471471
ggml_backend_buffer_t ggml_backend_dev_buffer_from_host_ptr(ggml_backend_dev_t device, void * ptr, size_t size, size_t max_tensor_size) {
@@ -491,11 +491,11 @@ const char * ggml_backend_reg_name(ggml_backend_reg_t reg) {
491491
}
492492

493493
size_t ggml_backend_reg_dev_count(ggml_backend_reg_t reg) {
494-
return reg->iface.device_count(reg);
494+
return reg->iface.get_device_count(reg);
495495
}
496496

497497
ggml_backend_dev_t ggml_backend_reg_dev_get(ggml_backend_reg_t reg, size_t index) {
498-
return reg->iface.device_get(reg, index);
498+
return reg->iface.get_device(reg, index);
499499
}
500500

501501
void * ggml_backend_reg_get_proc_address(ggml_backend_reg_t reg, const char * name) {
@@ -653,7 +653,7 @@ ggml_backend_t ggml_backend_init_best(void) {
653653

654654
static const size_t TENSOR_ALIGNMENT = 32; // required for mmap as gguf only guarantees 32-byte alignment
655655

656-
static const char * ggml_backend_cpu_buffer_name(ggml_backend_buffer_t buffer) {
656+
static const char * ggml_backend_cpu_buffer_get_name(ggml_backend_buffer_t buffer) {
657657
return "CPU";
658658

659659
GGML_UNUSED(buffer);
@@ -707,7 +707,7 @@ static void ggml_backend_cpu_buffer_clear(ggml_backend_buffer_t buffer, uint8_t
707707
}
708708

709709
static struct ggml_backend_buffer_i cpu_backend_buffer_i = {
710-
/* .get_name = */ ggml_backend_cpu_buffer_name,
710+
/* .get_name = */ ggml_backend_cpu_buffer_get_name,
711711
/* .free_buffer = */ ggml_backend_cpu_buffer_free_buffer,
712712
/* .get_base = */ ggml_backend_cpu_buffer_get_base,
713713
/* .init_tensor = */ NULL, // no initialization required
@@ -721,7 +721,7 @@ static struct ggml_backend_buffer_i cpu_backend_buffer_i = {
721721

722722
// for buffers from ptr, free is not called
723723
static struct ggml_backend_buffer_i cpu_backend_buffer_i_from_ptr = {
724-
/* .get_name = */ ggml_backend_cpu_buffer_name,
724+
/* .get_name = */ ggml_backend_cpu_buffer_get_name,
725725
/* .free_buffer = */ NULL, // ptr is not owned by the buffer, so it does not need to be freed
726726
/* .get_base = */ ggml_backend_cpu_buffer_get_base,
727727
/* .init_tensor = */ NULL, // no initialization required
@@ -846,7 +846,7 @@ struct ggml_backend_cpu_context {
846846
void * abort_callback_data;
847847
};
848848

849-
static const char * ggml_backend_cpu_name(ggml_backend_t backend) {
849+
static const char * ggml_backend_cpu_get_name(ggml_backend_t backend) {
850850
return "CPU";
851851

852852
GGML_UNUSED(backend);
@@ -932,7 +932,7 @@ static enum ggml_status ggml_backend_cpu_graph_compute(ggml_backend_t backend, s
932932
}
933933

934934
static struct ggml_backend_i cpu_backend_i = {
935-
/* .get_name = */ ggml_backend_cpu_name,
935+
/* .get_name = */ ggml_backend_cpu_get_name,
936936
/* .free = */ ggml_backend_cpu_free,
937937
/* .get_default_buffer_type = */ ggml_backend_cpu_get_default_buffer_type,
938938
/* .set_tensor_async = */ NULL,
@@ -1022,38 +1022,38 @@ ggml_backend_buffer_t ggml_backend_cpu_buffer_from_ptr(void * ptr, size_t size)
10221022

10231023
////////////////////////
10241024

1025-
static const char * ggml_backend_cpu_device_name(ggml_backend_dev_t dev) {
1025+
static const char * ggml_backend_cpu_device_get_name(ggml_backend_dev_t dev) {
10261026
return "CPU";
10271027

10281028
GGML_UNUSED(dev);
10291029
}
10301030

1031-
static const char * ggml_backend_cpu_device_description(ggml_backend_dev_t dev) {
1031+
static const char * ggml_backend_cpu_device_get_description(ggml_backend_dev_t dev) {
10321032
// TODO
10331033
return "CPU";
10341034

10351035
GGML_UNUSED(dev);
10361036
}
10371037

1038-
static void ggml_backend_cpu_device_memory(ggml_backend_dev_t dev, size_t * free, size_t * total) {
1038+
static void ggml_backend_cpu_device_get_memory(ggml_backend_dev_t dev, size_t * free, size_t * total) {
10391039
// TODO
10401040
*free = 0;
10411041
*total = 0;
10421042

10431043
GGML_UNUSED(dev);
10441044
}
10451045

1046-
static enum ggml_backend_dev_type ggml_backend_cpu_device_type(ggml_backend_dev_t dev) {
1046+
static enum ggml_backend_dev_type ggml_backend_cpu_device_get_type(ggml_backend_dev_t dev) {
10471047
return GGML_BACKEND_DEVICE_TYPE_CPU_FULL;
10481048

10491049
GGML_UNUSED(dev);
10501050
}
10511051

1052-
static void ggml_backend_cpu_device_props(ggml_backend_dev_t dev, struct ggml_backend_dev_props * props) {
1053-
props->name = ggml_backend_cpu_device_name(dev);
1054-
props->description = ggml_backend_cpu_device_description(dev);
1055-
props->type = ggml_backend_cpu_device_type(dev);
1056-
ggml_backend_cpu_device_memory(dev, &props->memory_free, &props->memory_total);
1052+
static void ggml_backend_cpu_device_get_props(ggml_backend_dev_t dev, struct ggml_backend_dev_props * props) {
1053+
props->name = ggml_backend_cpu_device_get_name(dev);
1054+
props->description = ggml_backend_cpu_device_get_description(dev);
1055+
props->type = ggml_backend_cpu_device_get_type(dev);
1056+
ggml_backend_cpu_device_get_memory(dev, &props->memory_free, &props->memory_total);
10571057
props->caps = {
10581058
/* async */ false,
10591059
/* host_buffer */ false,
@@ -1068,7 +1068,7 @@ static ggml_backend_t ggml_backend_cpu_device_init(ggml_backend_dev_t dev, const
10681068
GGML_UNUSED(params);
10691069
}
10701070

1071-
static ggml_backend_buffer_type_t ggml_backend_cpu_device_buffer_type(ggml_backend_dev_t dev) {
1071+
static ggml_backend_buffer_type_t ggml_backend_cpu_device_get_buffer_type(ggml_backend_dev_t dev) {
10721072
return ggml_backend_cpu_buffer_type();
10731073

10741074
GGML_UNUSED(dev);
@@ -1111,14 +1111,14 @@ static bool ggml_backend_cpu_device_supports_buft(ggml_backend_dev_t dev, ggml_b
11111111
}
11121112

11131113
static struct ggml_backend_device_i ggml_backend_cpu_device_i = {
1114-
/* .get_name = */ ggml_backend_cpu_device_name,
1115-
/* .get_description = */ ggml_backend_cpu_device_description,
1116-
/* .get_memory = */ ggml_backend_cpu_device_memory,
1117-
/* .get_type = */ ggml_backend_cpu_device_type,
1118-
/* .get_props = */ ggml_backend_cpu_device_props,
1114+
/* .get_name = */ ggml_backend_cpu_device_get_name,
1115+
/* .get_description = */ ggml_backend_cpu_device_get_description,
1116+
/* .get_memory = */ ggml_backend_cpu_device_get_memory,
1117+
/* .get_type = */ ggml_backend_cpu_device_get_type,
1118+
/* .get_props = */ ggml_backend_cpu_device_get_props,
11191119
/* .init_backend = */ ggml_backend_cpu_device_init,
1120-
/* .buffer_type = */ ggml_backend_cpu_device_buffer_type,
1121-
/* .host_buffer_type = */ NULL,
1120+
/* .get_buffer_type = */ ggml_backend_cpu_device_get_buffer_type,
1121+
/* .get_host_buffer_type = */ NULL,
11221122
/* .buffer_from_host_ptr = */ ggml_backend_cpu_device_buffer_from_ptr,
11231123
/* .supports_op = */ ggml_backend_cpu_device_supports_op,
11241124
/* .supports_buft = */ ggml_backend_cpu_device_supports_buft,
@@ -1130,19 +1130,19 @@ static struct ggml_backend_device_i ggml_backend_cpu_device_i = {
11301130

11311131
////////////////////////
11321132

1133-
static const char * ggml_backend_cpu_reg_name(ggml_backend_reg_t reg) {
1133+
static const char * ggml_backend_cpu_reg_get_name(ggml_backend_reg_t reg) {
11341134
return "CPU";
11351135

11361136
GGML_UNUSED(reg);
11371137
}
11381138

1139-
static size_t ggml_backend_cpu_reg_device_count(ggml_backend_reg_t reg) {
1139+
static size_t ggml_backend_cpu_reg_get_device_count(ggml_backend_reg_t reg) {
11401140
return 1;
11411141

11421142
GGML_UNUSED(reg);
11431143
}
11441144

1145-
static ggml_backend_dev_t ggml_backend_cpu_reg_device_get(ggml_backend_reg_t reg, size_t index) {
1145+
static ggml_backend_dev_t ggml_backend_cpu_reg_get_device(ggml_backend_reg_t reg, size_t index) {
11461146
GGML_ASSERT(index == 0);
11471147

11481148
static ggml_backend_device ggml_backend_cpu_device = {
@@ -1158,9 +1158,9 @@ static ggml_backend_dev_t ggml_backend_cpu_reg_device_get(ggml_backend_reg_t reg
11581158
}
11591159

11601160
static struct ggml_backend_reg_i ggml_backend_cpu_reg_i = {
1161-
/* .get_name = */ ggml_backend_cpu_reg_name,
1162-
/* .device_count = */ ggml_backend_cpu_reg_device_count,
1163-
/* .device_get = */ ggml_backend_cpu_reg_device_get,
1161+
/* .get_name = */ ggml_backend_cpu_reg_get_name,
1162+
/* .get_device_count = */ ggml_backend_cpu_reg_get_device_count,
1163+
/* .get_device = */ ggml_backend_cpu_reg_get_device,
11641164
/* .get_proc_address = */ NULL,
11651165
/* .set_log_callback = */ NULL,
11661166
};

0 commit comments

Comments
 (0)