ggml : fix another case of quants nans (#7387)

slaren · web-flow · commit e4e6f67be6a8 · 2024-05-19T17:08:46.000+02:00
diff --git a/ggml-quants.c b/ggml-quants.c
@@ -1149,7 +1149,7 @@ static float make_qx_quants(int n, int nmax, const float * restrict x, int8_t *
         sumlx += w*x[i]*l;
         suml2 += w*l*l;
     }
-    float scale = sumlx/suml2;
+    float scale = suml2 ? sumlx/suml2 : 0.0f;
     if (return_early) return suml2 > 0 ? 0.5f*(scale + 1/iscale) : 1/iscale;
     float best = scale * sumlx;
     for (int is = -9; is <= 9; ++is) {

Original file line number	Diff line number	Diff line change
`@@ -1149,7 +1149,7 @@ static float make_qx_quants(int n, int nmax, const float * restrict x, int8_t *`
`1149`	`1149`	`sumlx += wx[i]l;`
`1150`	`1150`	`suml2 += wll;`
`1151`	`1151`	`}`
`1152`		`- float scale = sumlx/suml2;`
	`1152`	`+ float scale = suml2 ? sumlx/suml2 : 0.0f;`
`1153`	`1153`	`if (return_early) return suml2 > 0 ? 0.5f*(scale + 1/iscale) : 1/iscale;`
`1154`	`1154`	`float best = scale * sumlx;`
`1155`	`1155`	`for (int is = -9; is <= 9; ++is) {`