Skip to content

Commit edd2546

Browse files
vulkan: Make sure workgroup size is defined before being referenced
1 parent 118b4f0 commit edd2546

12 files changed

+27
-27
lines changed

ggml/src/ggml-vulkan/vulkan-shaders/copy_from_quant.comp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
#version 450
22

3-
#include "types.comp"
4-
#include "generic_unary_head.comp"
5-
#include "dequant_funcs.comp"
6-
73
#if defined(DATA_A_IQ4_NL)
84
// 16 invocations needed for init_iq4nl_shmem
95
layout(local_size_x = 16, local_size_y = 1, local_size_z = 1) in;
106
#else
117
layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;
128
#endif
139

10+
#include "types.comp"
11+
#include "generic_unary_head.comp"
12+
#include "dequant_funcs.comp"
13+
1414
void main() {
1515
#if defined(DATA_A_IQ2_XXS) || defined(DATA_A_IQ2_XS) || defined(DATA_A_IQ2_S) || defined(DATA_A_IQ3_XXS) || defined(DATA_A_IQ3_S) || defined(DATA_A_IQ4_NL)
1616
init_iq_shmem();

ggml/src/ggml-vulkan/vulkan-shaders/copy_to_quant.comp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
#version 450
22

3-
#include "types.comp"
4-
#include "generic_unary_head.comp"
5-
63
#if defined(DATA_A_IQ4_NL)
74
// 16 invocations needed for init_iq4nl_shmem
85
layout(local_size_x = 16, local_size_y = 1, local_size_z = 1) in;
96
#else
107
layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;
118
#endif
129

10+
#include "types.comp"
11+
#include "generic_unary_head.comp"
12+
1313
layout (binding = 0) readonly buffer S {float data_s[];};
1414
layout (binding = 1) writeonly buffer Q {A_TYPE data_q[];};
1515

ggml/src/ggml-vulkan/vulkan-shaders/dequant_iq2_s.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#version 450
22

3-
#include "dequant_head.comp"
4-
53
layout(local_size_x = 256, local_size_y = 1, local_size_z = 1) in;
64

5+
#include "dequant_head.comp"
6+
77
layout (binding = 0) readonly buffer A {block_iq2_s data_a[];};
88
layout (binding = 1) writeonly buffer D {D_TYPE data_b[];};
99

ggml/src/ggml-vulkan/vulkan-shaders/dequant_iq2_xs.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#version 450
22

3-
#include "dequant_head.comp"
4-
53
layout(local_size_x = 256, local_size_y = 1, local_size_z = 1) in;
64

5+
#include "dequant_head.comp"
6+
77
layout (binding = 0) readonly buffer A {block_iq2_xs data_a[];};
88
layout (binding = 1) writeonly buffer D {D_TYPE data_b[];};
99

ggml/src/ggml-vulkan/vulkan-shaders/dequant_iq2_xxs.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#version 450
22

3-
#include "dequant_head.comp"
4-
53
layout(local_size_x = 256, local_size_y = 1, local_size_z = 1) in;
64

5+
#include "dequant_head.comp"
6+
77
layout (binding = 0) readonly buffer A {block_iq2_xxs data_a[];};
88
layout (binding = 1) writeonly buffer D {D_TYPE data_b[];};
99

ggml/src/ggml-vulkan/vulkan-shaders/dequant_iq3_s.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#version 450
22

3-
#include "dequant_head.comp"
4-
53
layout(local_size_x = 256, local_size_y = 1, local_size_z = 1) in;
64

5+
#include "dequant_head.comp"
6+
77
layout (binding = 0) readonly buffer A {block_iq3_s data_a[];};
88
layout (binding = 1) writeonly buffer D {D_TYPE data_b[];};
99

ggml/src/ggml-vulkan/vulkan-shaders/dequant_iq3_xxs.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#version 450
22

3-
#include "dequant_head.comp"
4-
53
layout(local_size_x = 256, local_size_y = 1, local_size_z = 1) in;
64

5+
#include "dequant_head.comp"
6+
77
layout (binding = 0) readonly buffer A {block_iq3_xxs data_a[];};
88
layout (binding = 1) writeonly buffer D {D_TYPE data_b[];};
99

ggml/src/ggml-vulkan/vulkan-shaders/flash_attn_cm2.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
#extension GL_KHR_shader_subgroup_vote : enable
1717
#extension GL_EXT_null_initializer : enable
1818

19+
layout(local_size_x_id = 0, local_size_y = 1, local_size_z = 1) in;
20+
1921
#include "types.comp"
2022
#include "dequant_funcs_cm2.comp"
2123

22-
layout(local_size_x_id = 0, local_size_y = 1, local_size_z = 1) in;
23-
2424
layout (constant_id = 1) const uint32_t Br = 32;
2525
layout (constant_id = 2) const uint32_t Bc = 32;
2626
layout (constant_id = 3) const uint32_t D = 32;

ggml/src/ggml-vulkan/vulkan-shaders/get_rows_quant.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
#version 450
22

3+
layout(local_size_x = 512, local_size_y = 1, local_size_z = 1) in;
4+
35
#include "types.comp"
46
#include "generic_binary_head.comp"
57
#include "dequant_funcs.comp"
68

7-
layout(local_size_x = 512, local_size_y = 1, local_size_z = 1) in;
8-
99
void main() {
1010
const uint i00 = (gl_GlobalInvocationID.x)*2;
1111
const uint i10 = gl_GlobalInvocationID.y;

ggml/src/ggml-vulkan/vulkan-shaders/mul_mat_vec.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
#extension GL_EXT_shader_explicit_arithmetic_types_int32 : require
44

5-
#include "mul_mat_vec_base.comp"
6-
75
layout(local_size_x_id = 0, local_size_y = 1, local_size_z = 1) in;
86

7+
#include "mul_mat_vec_base.comp"
8+
99
#if !defined(DATA_A_F32) && !defined(DATA_A_F16)
1010
#define K_PER_ITER 8
1111
#else

ggml/src/ggml-vulkan/vulkan-shaders/mul_mm.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
#extension GL_EXT_shader_explicit_arithmetic_types_int16 : require
1818
#endif
1919

20+
layout(local_size_x_id = 0, local_size_y = 1, local_size_z = 1) in;
21+
2022
#include "types.comp"
2123

2224
#ifndef LOAD_VEC_A
@@ -26,8 +28,6 @@
2628
#define LOAD_VEC_B 1
2729
#endif
2830

29-
layout(local_size_x_id = 0, local_size_y = 1, local_size_z = 1) in;
30-
3131
layout (binding = 0) readonly buffer A {A_TYPE data_a[];};
3232
layout (binding = 1) readonly buffer B {B_TYPE data_b[];};
3333
layout (binding = 2) writeonly buffer D {D_TYPE data_d[];};

ggml/src/ggml-vulkan/vulkan-shaders/mul_mm_cm2.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
#extension GL_KHR_shader_subgroup_ballot : enable
1616
#extension GL_KHR_shader_subgroup_vote : enable
1717

18-
#include "types.comp"
19-
2018
layout(local_size_x_id = 0, local_size_y = 1, local_size_z = 1) in;
2119

20+
#include "types.comp"
21+
2222
layout (constant_id = 1) const uint BM = 64;
2323
layout (constant_id = 2) const uint BN = 64;
2424
layout (constant_id = 3) const uint BK = 16; // Assumed to be 32 if working with a quant

0 commit comments

Comments
 (0)