Skip to content

Commit f4682ee

Browse files
committed
speculative : add grammar support
1 parent 47068e5 commit f4682ee

File tree

3 files changed

+102
-3
lines changed

3 files changed

+102
-3
lines changed

examples/speculative/speculative.cpp

Lines changed: 79 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
#include "common.h"
88
#include "llama.h"
9+
#include "grammar-parser.h"
910

1011
#include <cmath>
1112
#include <cstdio>
@@ -109,6 +110,41 @@ int main(int argc, char ** argv) {
109110
// used to determine end of generation
110111
bool has_eos = false;
111112

113+
// grammar stuff
114+
struct llama_grammar * grammar_dft = NULL;
115+
struct llama_grammar * grammar_tgt = NULL;
116+
117+
grammar_parser::parse_state parsed_grammar_dft;
118+
grammar_parser::parse_state parsed_grammar_tgt;
119+
120+
std::vector<llama_grammar *> grammar_mem(n_draft, NULL);
121+
122+
if (!params.grammar.empty()) {
123+
// dft
124+
{
125+
parsed_grammar_dft = grammar_parser::parse(params.grammar.c_str());
126+
// will be empty (default) if there are parse errors
127+
if (parsed_grammar_dft.rules.empty()) {
128+
return 1;
129+
}
130+
131+
std::vector<const llama_grammar_element *> grammar_rules(parsed_grammar_dft.c_rules());
132+
grammar_dft = llama_grammar_init(grammar_rules.data(), grammar_rules.size(), parsed_grammar_dft.symbol_ids.at("root"));
133+
}
134+
135+
// tgt
136+
{
137+
parsed_grammar_tgt = grammar_parser::parse(params.grammar.c_str());
138+
// will be empty (default) if there are parse errors
139+
if (parsed_grammar_tgt.rules.empty()) {
140+
return 1;
141+
}
142+
143+
std::vector<const llama_grammar_element *> grammar_rules(parsed_grammar_tgt.c_rules());
144+
grammar_tgt = llama_grammar_init(grammar_rules.data(), grammar_rules.size(), parsed_grammar_tgt.symbol_ids.at("root"));
145+
}
146+
}
147+
112148
const auto t_dec_start = ggml_time_us();
113149

114150
while (true) {
@@ -117,7 +153,7 @@ int main(int argc, char ** argv) {
117153
// sample from the drafted tokens if any
118154
int i_dft = 0;
119155
while (true) {
120-
const llama_token id = llama_sample_token(ctx_tgt, NULL, NULL, params, last_tokens, candidates, i_dft);
156+
const llama_token id = llama_sample_token(ctx_tgt, NULL, grammar_tgt, params, last_tokens, candidates, i_dft);
121157

122158
last_tokens.erase(last_tokens.begin());
123159
last_tokens.push_back(id);
@@ -144,13 +180,35 @@ int main(int argc, char ** argv) {
144180
continue;
145181
}
146182

183+
if (i_dft < (int) drafted.size()) {
184+
LOG("drafted token %d rejected\n", id);
185+
186+
if (grammar_mem[i_dft]) {
187+
grammar_dft = llama_grammar_copy(grammar_mem[i_dft]);
188+
LOG("restored grammar %d\n", i_dft);
189+
}
190+
}
191+
192+
for (auto & g : grammar_mem) {
193+
if (g) {
194+
llama_grammar_free(g);
195+
g = NULL;
196+
}
197+
}
198+
199+
LOG("i_dft = %d, drafted.size() = %d\n", i_dft, (int) drafted.size());
200+
147201
// the drafted token was rejected or we are out of drafted tokens
148202
llama_eval(ctx_dft, &id, 1, n_past_dft, params.n_threads);
149203
++n_past_dft;
150204

151205
drafted.clear();
152206
drafted.push_back(id);
153207

208+
if (grammar_dft != NULL) {
209+
llama_grammar_accept_token(ctx_dft, grammar_dft, id);
210+
}
211+
154212
break;
155213
}
156214

@@ -161,6 +219,11 @@ int main(int argc, char ** argv) {
161219
// sample n_draft tokens from the draft model picking the best token
162220
int n_past_cur = n_past_dft;
163221
for (int i = 0; i < n_draft; ++i) {
222+
// remember the grammar state
223+
if (grammar_dft != NULL) {
224+
grammar_mem[i] = llama_grammar_copy(grammar_dft);
225+
}
226+
164227
float * logits = llama_get_logits(ctx_dft);
165228

166229
candidates.clear();
@@ -170,6 +233,10 @@ int main(int argc, char ** argv) {
170233

171234
llama_token_data_array cur_p = { candidates.data(), candidates.size(), false };
172235

236+
if (grammar_dft != NULL) {
237+
llama_sample_grammar(ctx_dft, &cur_p, grammar_dft);
238+
}
239+
173240
// computes softmax and sorts the candidates
174241
llama_sample_softmax(ctx_dft, &cur_p);
175242

@@ -182,7 +249,13 @@ int main(int argc, char ** argv) {
182249
break;
183250
}
184251

185-
drafted.push_back(cur_p.data[0].id);
252+
const llama_token id = cur_p.data[0].id;
253+
254+
if (grammar_dft != NULL) {
255+
llama_grammar_accept_token(ctx_dft, grammar_dft, id);
256+
}
257+
258+
drafted.push_back(id);
186259
++n_drafted;
187260

188261
if (i < n_draft - 1) {
@@ -226,6 +299,10 @@ int main(int argc, char ** argv) {
226299
llama_free(ctx_dft);
227300
llama_free_model(model_dft);
228301

302+
if (grammar_dft != NULL) {
303+
llama_grammar_free(grammar_dft);
304+
llama_grammar_free(grammar_tgt);
305+
}
229306
llama_backend_free();
230307

231308
fprintf(stderr, "\n\n");

llama.cpp

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3488,7 +3488,7 @@ struct llama_grammar {
34883488
std::vector<std::vector<const llama_grammar_element *>> stacks;
34893489

34903490
// buffer for partially generated UTF-8 sequence from accepted tokens
3491-
llama_partial_utf8 partial_utf8;
3491+
llama_partial_utf8 partial_utf8;
34923492
};
34933493

34943494
struct llama_grammar_candidate {
@@ -3850,6 +3850,26 @@ void llama_grammar_free(struct llama_grammar * grammar) {
38503850
delete grammar;
38513851
}
38523852

3853+
struct llama_grammar * llama_grammar_copy(const struct llama_grammar * grammar) {
3854+
llama_grammar * result = new llama_grammar{ grammar->rules, grammar->stacks, grammar->partial_utf8 };
3855+
3856+
// redirect elements in stacks to point to new rules
3857+
for (size_t is = 0; is < result->stacks.size(); is++) {
3858+
for (size_t ie = 0; ie < result->stacks[is].size(); ie++) {
3859+
for (size_t ir0 = 0; ir0 < grammar->rules.size(); ir0++) {
3860+
for (size_t ir1 = 0; ir1 < grammar->rules[ir0].size(); ir1++) {
3861+
if (grammar->stacks[is][ie] == &grammar->rules[ir0][ir1]) {
3862+
result->stacks[is][ie] = &result->rules[ir0][ir1];
3863+
}
3864+
}
3865+
}
3866+
3867+
}
3868+
}
3869+
3870+
return result;
3871+
}
3872+
38533873
//
38543874
// sampling
38553875
//

llama.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,8 @@ extern "C" {
410410

411411
LLAMA_API void llama_grammar_free(struct llama_grammar * grammar);
412412

413+
LLAMA_API struct llama_grammar * llama_grammar_copy(const struct llama_grammar * grammar);
414+
413415
//
414416
// Sampling functions
415417
//

0 commit comments

Comments
 (0)