refactor(build): fix build warnings & downgrade ng-packgr to build

Author: Ghislain Beaulac

package.json

@@ -34,8 +34,8 @@
     "test:watch": "npm-run-all jest:watch",
     "copy:i18n": "cross-env copyfiles -f src/assets/i18n/*.json dist/i18n",
     "copy:lib": "cross-env copyfiles --up 2 src/assets/lib/** dist",
-    "copy-demo:dist": "cross-env copyfiles --up 1 dist/**/*.* ../Angular-Slickgrid-demo/node_modules/angular-slickgrid",
-    "del-demo:dist": "cross-env rimraf ../Angular-Slickgrid-demo/node_modules/angular-slickgrid",
+    "copy-demo:dist": "cross-env copyfiles --up 1 dist/**/*.* ../angular-slickgrid-demos/bootstrap3-demo-with-translate/node_modules/angular-slickgrid",
+    "del-demo:dist": "cross-env rimraf ../angular-slickgrid-demos/bootstrap3-demo-with-translate/node_modules/angular-slickgrid",
     "pack-lib": "npm pack ./dist",
     "packagr": "ng-packagr -p package.json",
     "changelog": "cross-env conventional-changelog -p angular -i doc/CHANGELOG.md -s",
@@ -133,7 +133,7 @@
     "jest-extended": "^0.11.1",
     "jest-junit": "^6.4.0",
     "jest-preset-angular": "^6.0.1",
-    "ng-packagr": "^5.2.0",
+    "ng-packagr": "~5.3.0",
     "ngx-bootstrap": "^4.3.0",
     "node-sass": "^4.12.0",
     "npm-run-all": "^4.1.5",

src/app/modules/angular-slickgrid/filter-conditions/executeMappedCondition.ts

@@ -7,7 +7,8 @@ import { stringFilterCondition } from './stringFilterCondition';
 import { FieldType, FilterCondition, FilterConditionOption, OperatorType } from '../models/index';
 import { mapMomentDateFormatWithFieldType } from './../services/utilities';
 import { testFilterCondition } from './filterUtilities';
-import * as moment from 'moment-mini';
+import * as moment_ from 'moment-mini';
+const moment = moment_; // patch to fix rollup "moment has no default export" issue, document here https://github.com/rollup/rollup/issues/670
 
 export const executeMappedCondition: FilterCondition = (options: FilterConditionOption) => {
   // when using a multi-select ('IN' operator) we will not use the field type but instead go directly with a collection search
@@ -67,8 +68,8 @@ function executeAssociatedDateCondition(options: FilterConditionOption): boolean
   const searchTerms = Array.isArray(options.searchTerms) && options.searchTerms || [];
 
   let isRangeSearch = false;
-  let dateSearch1: moment.Moment;
-  let dateSearch2: moment.Moment;
+  let dateSearch1: any;
+  let dateSearch2: any;
 
   // return when cell value is not a valid date
   if (searchTerms.length === 0 || searchTerms[0] === '' || searchTerms[0] === null || !moment(options.cellValue, FORMAT, true).isValid()) {

src/app/modules/angular-slickgrid/sorters/dateUtilities.ts

@@ -1,8 +1,9 @@
 import { mapMomentDateFormatWithFieldType } from '../services/utilities';
 import { FieldType, Sorter } from '../models/index';
-import * as moment from 'moment-mini';
+import * as moment_ from 'moment-mini';
+const moment = moment_; // patch to fix rollup "moment has no default export" issue, document here https://github.com/rollup/rollup/issues/670
 
-export function compareDates(value1: any, value2: any, sortDirection: number, format: string | moment.MomentBuiltinFormat, strict?: boolean) {
+export function compareDates(value1: any, value2: any, sortDirection: number, format: string | moment_.MomentBuiltinFormat, strict?: boolean) {
   let diff = 0;
 
   if (value1 === null || value1 === '' || !moment(value1, format, strict).isValid()) {