refactor(tests): rename service spec file & cleanup some code

Author: Ghislain Beaulac

src/app/modules/angular-slickgrid/services/__tests__/odata.service.spec.ts renamed to src/app/modules/angular-slickgrid/services/__tests__/odataQueryBuilder.service.spec.ts

@@ -1,52 +1,10 @@
 import { CaseType } from '../../models/caseType';
 import { OdataQueryBuilderService } from '../odataQueryBuilder.service';
-import {
-  Column,
-  ColumnFilter,
-  ColumnSort,
-  CurrentFilter,
-  FilterChangedArgs,
-  GridOption,
-  MultiColumnSort,
-  Pagination,
-  ColumnFilters,
-  OperatorType,
-  FieldType,
-  CurrentSorter,
-  OdataOption,
-} from '../../models';
-
-const DEFAULT_ITEMS_PER_PAGE = 25;
-const DEFAULT_PAGE_SIZE = 20;
-
-const gridOptionMock = {
-  enablePagination: true,
-  backendServiceApi: {
-    service: undefined,
-    preProcess: jest.fn(),
-    process: jest.fn(),
-    postProcess: jest.fn(),
-  }
-} as GridOption;
-
-const gridStub = {
-  autosizeColumns: jest.fn(),
-  getColumnIndex: jest.fn(),
-  getScrollbarDimensions: jest.fn(),
-  getOptions: () => gridOptionMock,
-  getColumns: jest.fn(),
-  setColumns: jest.fn(),
-  registerPlugin: jest.fn(),
-  setSelectedRows: jest.fn(),
-  setSortColumns: jest.fn(),
-};
-
-describe('OdataService', () => {
-  let mockColumns: Column[];
+
+describe('OdataQueryBuilderService', () => {
   let service: OdataQueryBuilderService;
 
   beforeEach(() => {
-    mockColumns = [{ id: 'field1', field: 'field1', width: 100 }, { id: 'field2', field: 'field2', width: 100 }];
     service = new OdataQueryBuilderService();
   });
 

src/app/modules/angular-slickgrid/services/graphql.service.ts

@@ -556,7 +556,7 @@ export class GraphqlService implements BackendService {
    */
   private castFilterToColumnFilters(columnFilters: ColumnFilters | CurrentFilter[]): CurrentFilter[] {
     if (!Array.isArray(columnFilters)) {
-      return null;
+      return [];
     }
 
     // keep current filters & always save it as an array (columnFilters can be an object when it is dealt by SlickGrid Filter)

src/app/modules/angular-slickgrid/services/grid-odata.service.ts

@@ -75,7 +75,7 @@ export class GridOdataService implements BackendService {
     // save current pagination as Page 1 and page size as "top"
     this._currentPagination = {
       pageNumber: 1,
-      pageSize: this._odataService.options.top || this.defaultOptions.top
+      pageSize: this._odataService.options.top || this.defaultOptions.top || DEFAULT_PAGE_SIZE
     };
 
     if (grid && grid.getColumns) {
@@ -490,7 +490,7 @@ export class GridOdataService implements BackendService {
    */
   private castFilterToColumnFilters(columnFilters: ColumnFilters | CurrentFilter[]): CurrentFilter[] {
     if (!Array.isArray(columnFilters)) {
-      return null;
+      return [];
     }
 
     // keep current filters & always save it as an array (columnFilters can be an object when it is dealt by SlickGrid Filter)