Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Commit 9b923a8

Browse files
authored
Merge pull request #1342 from ghiscoding/chore/slickgrid-interface-removal
chore: remove unnecessary SlickGrid interface
2 parents 3f8bb3e + 7c38914 commit 9b923a8

File tree

8 files changed

+6
-14
lines changed

8 files changed

+6
-14
lines changed

cypress/downloads/downloads.htm

-4.97 KB
Binary file not shown.

src/app/examples/custom-angularComponentEditor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class CustomAngularComponentEditor implements Editor {
6262

6363
/** Getter for the Grid Options pulled through the Grid Object */
6464
get gridOptions(): GridOption {
65-
return this.grid?.getOptions() ?? {} as GridOption;
65+
return (this.grid?.getOptions() ?? {}) as GridOption;
6666
}
6767

6868
get hasAutoCommitEdit(): boolean {

src/app/examples/custom-angularComponentFilter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export class CustomAngularComponentFilter implements Filter {
4949

5050
/** Getter for the Grid Options pulled through the Grid Object */
5151
get gridOptions(): GridOption {
52-
return this.grid?.getOptions?.() as GridOption;
52+
return (this.grid?.getOptions() ?? {}) as GridOption;
5353
}
5454

5555
/**

src/app/examples/custom-inputFilter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export class CustomInputFilter implements Filter {
2828

2929
/** Getter for the Grid Options pulled through the Grid Object */
3030
get gridOptions(): GridOption {
31-
return this.grid?.getOptions() as GridOption;
31+
return (this.grid?.getOptions() ?? {}) as GridOption;
3232
}
3333

3434
/**

src/app/examples/grid-contextmenu.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const priorityExportFormatter: Formatter = (row, cell, value, columnDef, dataCon
4242
if (!value) {
4343
return '';
4444
}
45-
const gridOptions = ((grid && typeof grid.getOptions === 'function') ? grid.getOptions() : {}) as GridOption;
45+
const gridOptions = grid.getOptions() as GridOption;
4646
const translate = gridOptions.i18n;
4747
const count = +(value >= 3 ? 3 : value);
4848
const key = count === 3 ? 'HIGH' : (count === 2 ? 'MEDIUM' : 'LOW');

src/app/modules/angular-slickgrid/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export * from '@slickgrid-universal/common';
22

33
// Public classes.
4-
export { AngularComponentOutput, AngularGridInstance, GridOption, SlickGrid, RowDetailView } from './models/index';
4+
export { AngularComponentOutput, AngularGridInstance, GridOption, RowDetailView } from './models/index';
55
export { AngularUtilService, unsubscribeAllObservables } from './services/index';
66
export { SlickRowDetailView } from './extensions/index';
77

src/app/modules/angular-slickgrid/models/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@ export * from './angularComponentOutput.interface';
22
export * from './angularGridInstance.interface';
33
export * from './externalTestingDependencies.interface';
44
export * from './gridOption.interface';
5-
export * from './rowDetailView.interface';
6-
export * from './slickGrid.interface';
5+
export * from './rowDetailView.interface';

src/app/modules/angular-slickgrid/models/slickGrid.interface.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)