filesystem: remove unused mock function

Remove mock of 'UserHomeDir()' for the 'FileSystem' interface leftover from
an earlier iteration of de58f24 (repo: add more GetRepositories() tests, fix
bug, 2023-01-31). The function was removed by the time the commit was
merged, so the mock can safely be deleted.

Add a call to 'mock.AssertExpectationsForObjects()' to ensure all mocked
functions are called. This function should be called in all mocked unit
tests to ensure similar issues do not occur in the future.

Signed-off-by: Victoria Dye <[email protected]>

Author: vdye

internal/core/repo_test.go

@@ -97,12 +97,12 @@ func TestRepos_GetRepositories(t *testing.T) {
 
 	for _, tt := range getRepositoriesTests {
 		t.Run(tt.title, func(t *testing.T) {
-			testFileSystem.On("UserHomeDir").Return("/my/test/dir", nil)
 			testFileSystem.On("ReadFileLines",
 				mock.AnythingOfType("string"),
 			).Return(tt.readFileLines.First, tt.readFileLines.Second).Once()
 
 			actual, err := repoProvider.GetRepositories(context.Background())
+			mock.AssertExpectationsForObjects(t, testUserProvider, testFileSystem)
 
 			if tt.expectedErr {
 				assert.NotNil(t, err, "Expected error")

internal/testhelpers/mocks.go

@@ -196,11 +196,6 @@ func (m *MockFileSystem) ReadFileLines(filename string) ([]string, error) {
 	return fnArgs.Get(0).([]string), fnArgs.Error(1)
 }
 
-func (m *MockFileSystem) UserHomeDir() (string, error) {
-	fnArgs := m.Called()
-	return fnArgs.String(0), fnArgs.Error(1)
-}
-
 type MockGitHelper struct {
 	mock.Mock
 }