Merge pull request #26 from github/vdye/init-bugfix

File creation bugfix for `init` + misc cleanup

Author: vdye

Wishlist.md

@@ -63,9 +63,16 @@ func (f *fileSystem) DeleteFile(filename string) (bool, error) {
 }
 
 func (f *fileSystem) ReadFileLines(filename string) ([]string, error) {
-	file, err := os.OpenFile(filename, os.O_RDONLY|os.O_CREATE, 0o600)
+	file, err := os.Open(filename)
 	if err != nil {
-		return nil, err
+		pathErr, ok := err.(*os.PathError)
+		if ok && pathErr.Err == syscall.ENOENT {
+			// If the file doesn't exist, return empty result rather than an
+			// error
+			return []string{}, nil
+		} else {
+			return nil, err
+		}
 	}
 
 	var l []string

doc.go

@@ -23,7 +23,7 @@ func CreateRepository(route string) (*Repository, error) {
 	fs := common.NewFileSystem()
 	repos, err := GetRepositories(user, fs)
 	if err != nil {
-		return nil, fmt.Errorf("failed to parse routes file")
+		return nil, fmt.Errorf("failed to parse routes file: %w", err)
 	}
 
 	repo, contains := repos[route]
@@ -63,7 +63,7 @@ func RemoveRoute(route string) error {
 	fs := common.NewFileSystem()
 	repos, err := GetRepositories(user, fs)
 	if err != nil {
-		return fmt.Errorf("failed to parse routes file")
+		return fmt.Errorf("failed to parse routes file: %w", err)
 	}
 
 	_, contains := repos[route]