Skip to content

Commit af9cff5

Browse files
committed
please.sh update_vs_branch: no longer pass MSVC=1
Since af5e32d0d3e (Merge pull request #1304 from jeffhostetler/vs2017_vcpkg, 2017-12-20), it is neither necessary nor advisable to use MSVC=1 for the vcxproj target: it would initialize the vcpkg system, requiring a Visual Studio installation (which is, funnily enough, not necessary if only generating the Visual Studio projects). Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 27e9a79 commit af9cff5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

please.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1291,7 +1291,7 @@ update_vs_branch () { # [--worktree=<path>] [--remote=<remote>] [--branch=<branc
12911291
fi &&
12921292
git reset --hard &&
12931293
git checkout --force refs/remotes/"$remote/$branch"^0 &&
1294-
make MSVC=1 vcxproj &&
1294+
make vcxproj &&
12951295
git push "$remote" +HEAD:refs/heads/vs/"$branch" ||
12961296
die "Could not push vs/$branch\n") ||
12971297
exit

0 commit comments

Comments
 (0)