Skip to content

Commit 42bb09b

Browse files
committed
build-and-deploy: fix the run-name for MSYS builds
Seems that the `${{ ... }}` construct is not recursive: embedding it within itself won't have the inner one expanded. In other words, triggering an `i686` build of the `mintty` package resulted in this very ugly title: Build and deploy mintty (${{ inputs.architecture }}) For proof, see https://github.com/git-for-windows/git-for-windows-automation/actions/runs/3730919260 Let's avoid that by using the `format()` function described here: https://docs.github.com/en/actions/learn-github-actions/expressions#format Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 97791e8 commit 42bb09b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build-and-deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: build-and-deploy
2-
run-name: Build${{ inputs.build_only == '' && ' and deploy' || '' }} ${{ !startsWith(inputs.package, 'mingw-w64-') && inputs.repo != 'MSYS2-packages' && inputs.package != 'git-extra' && inputs.package != 'git-for-windows-keyring' && 'mingw-w64-' || '' }}${{ inputs.package }}${{ inputs.architecture && ' (${{ inputs.architecture }})' || '' }}
2+
run-name: Build${{ inputs.build_only == '' && ' and deploy' || '' }} ${{ !startsWith(inputs.package, 'mingw-w64-') && inputs.repo != 'MSYS2-packages' && inputs.package != 'git-extra' && inputs.package != 'git-for-windows-keyring' && 'mingw-w64-' || '' }}${{ inputs.package }}${{ inputs.architecture && format(' ({0})', inputs.architecture) || '' }}
33

44
on:
55
workflow_dispatch:

0 commit comments

Comments
 (0)