Skip to content

Commit db07009

Browse files
committed
release-git: require the announcement email to be sent manually
For quite a while now, those emails were rejected by the Git mailing list due to some Spamhaus rule. This is quite annoying, but cannot be helped because, well, because reasons. So let's just print out the announcement email to the log, thusly requiring a manual step after the release is done. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 1806891 commit db07009

File tree

1 file changed

+4
-19
lines changed

1 file changed

+4
-19
lines changed

.github/workflows/release-git.yml

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ jobs:
3030
tag-name: ${{ steps.bundle-artifacts.outputs.tag-name }}
3131
ver: ${{ steps.bundle-artifacts.outputs.ver }}
3232
git-rev: ${{ steps.bundle-artifacts.outputs.git-rev }}
33-
announcement: ${{ steps.bundle-artifacts.outputs.announcement }}
3433
release-notes: ${{ steps.bundle-artifacts.outputs.release-notes }}
3534
steps:
3635
- uses: actions/checkout@v4
@@ -99,7 +98,10 @@ jobs:
9998
core.setOutput('ver', result.ver)
10099
core.setOutput('git-rev', result.gitCommitOID)
101100
102-
core.setOutput('announcement', result.announcement)
101+
core.startGroup('Announcement email')
102+
core.info(result.announcement)
103+
core.endGroup()
104+
103105
core.setOutput('release-notes', result.releaseNotes)
104106
- name: Re-publish bundle-artifacts so the next job can easily use it
105107
uses: actions/upload-artifact@v4
@@ -126,23 +128,6 @@ jobs:
126128
git_artifacts_i686_workflow_run_id: ${{ env.I686_WORKFLOW_RUN_ID }}
127129
git_artifacts_x86_64_workflow_run_id: ${{ env.X86_64_WORKFLOW_RUN_ID }}
128130
git_artifacts_aarch64_workflow_run_id: ${{ env.AARCH64_WORKFLOW_RUN_ID }}
129-
announcement-mail:
130-
needs: ['setup', 'github-release']
131-
runs-on: ubuntu-latest
132-
steps:
133-
- name: Mail announcement
134-
uses: git-for-windows/git-for-windows-automation/.github/actions/mail-announcement@release
135-
with:
136-
app-id: ${{ secrets.GH_APP_ID }}
137-
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
138-
owner: ${{ env.OWNER }}
139-
repo: ${{ env.REPO }}
140-
display-version: ${{ needs.setup.outputs.display-version }}
141-
rev: ${{ needs.setup.outputs.git-rev }}
142-
announcement: ${{ needs.setup.outputs.announcement }}
143-
smtp-server: ${{ secrets.SEND_ANNOUNCEMENT_SMTP_SERVER }}
144-
smtp-login: ${{ secrets.SEND_ANNOUNCEMENT_SMTP_LOGIN }}
145-
smtp-password: ${{ secrets.SEND_ANNOUNCEMENT_SMTP_PASSWORD }}
146131
gitforwindows-site:
147132
needs: ['setup', 'github-release']
148133
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)