Skip to content

Commit 00f6991

Browse files
jlehmanngitster
authored andcommitted
t/Makefile: always test all lint targets when running tests
Only the two targets "test-lint-duplicates" and "test-lint-executable" are currently executed when running the test target. This was done on purpose when the TEST_LINT variable was added in 81127d7 to avoid twisted shell scripting by developers only to avoid false positives that might result from the rather simple minded tests, e.g. test-lint-shell-syntax. But it looks like it might be better to include all lint tests to help developers to detect non portable shell constructs before the patch is sent to the list and reviewed there. Change the TEST_LINT variable to run all lint test unless the TEST_LINT variable is overridden. If we hit false positives more often than helping developers to avoid non-portable code (or add less accurate or slow tests later) we could still fall back to exclude them like 81127d7 proposed. Signed-off-by: Jens Lehmann <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent cd78cea commit 00f6991

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ TAR ?= $(TAR)
1313
RM ?= rm -f
1414
PROVE ?= prove
1515
DEFAULT_TEST_TARGET ?= test
16-
TEST_LINT ?= test-lint-duplicates test-lint-executable
16+
TEST_LINT ?= test-lint
1717

1818
ifdef TEST_OUTPUT_DIRECTORY
1919
TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results

0 commit comments

Comments
 (0)