Skip to content

Commit 04b1f71

Browse files
derrickstoleeGit for Windows Build Agent
authored andcommitted
Merge pull request #3791: Various fixes around safe.directory
The first three commits are rebased versions of those in gitgitgadget#1215. These allow the following: 1. Fix `git config --global foo.bar <path>` from allowing the `<path>`. As a bonus, users with a config value starting with `/` will not get a warning about "old-style" paths needing a "`%(prefix)/`". 2. When in WSL, the path starts with `/` so it needs to be interpolated properly. Update the warning to include `%(prefix)/` to get the right value for WSL users. (This is specifically for using Git for Windows from Git Bash, but in a WSL directory.) 3. When using WSL, the ownership check fails and reports an error message. This is noisy, and happens even if the user has marked the path with `safe.directory`. Remove that error message.
2 parents 1da83d5 + 0f4462b commit 04b1f71

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

compat/mingw.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3165,9 +3165,7 @@ int is_path_owned_by_current_sid(const char *path, struct strbuf *report)
31653165
DACL_SECURITY_INFORMATION,
31663166
&sid, NULL, NULL, NULL, &descriptor);
31673167

3168-
if (err != ERROR_SUCCESS)
3169-
error(_("failed to get owner for '%s' (%ld)"), path, err);
3170-
else if (sid && IsValidSid(sid)) {
3168+
if (err == ERROR_SUCCESS && sid && IsValidSid(sid)) {
31713169
/* Now, verify that the SID matches the current user's */
31723170
static PSID current_user_sid;
31733171
static HANDLE linked_token;

setup.c

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1784,10 +1784,19 @@ const char *setup_git_directory_gently(int *nongit_ok)
17841784
break;
17851785
case GIT_DIR_INVALID_OWNERSHIP:
17861786
if (!nongit_ok) {
1787+
struct strbuf prequoted = STRBUF_INIT;
17871788
struct strbuf quoted = STRBUF_INIT;
17881789

17891790
strbuf_complete(&report, '\n');
1790-
sq_quote_buf_pretty(&quoted, dir.buf);
1791+
1792+
#ifdef __MINGW32__
1793+
if (dir.buf[0] == '/')
1794+
strbuf_addstr(&prequoted, "%(prefix)/");
1795+
#endif
1796+
1797+
strbuf_add(&prequoted, dir.buf, dir.len);
1798+
sq_quote_buf_pretty(&quoted, prequoted.buf);
1799+
17911800
die(_("detected dubious ownership in repository at '%s'\n"
17921801
"%s"
17931802
"To add an exception for this directory, call:\n"

0 commit comments

Comments
 (0)