Skip to content

Commit 0b18023

Browse files
davvidgitster
authored andcommitted
contrib/completion: fix zsh completion regression from 59d85a2
A recent change to make git-completion.bash use $__git_cmd_idx in more places broke a number of completions on zsh because it modified __git_main but did not update __git_zsh_main. Notably, completions for "add", "branch", "mv" and "push" were broken as a result of this change. In addition to the undefined variable usage, "git mv <tab>" also prints the following error: __git_count_arguments:7: bad math expression: operand expected at `"1"' _git_mv:[:7: unknown condition: -gt Remove the quotes around $__git_cmd_idx in __git_count_arguments and set __git_cmd_idx=1 early in __git_zsh_main to fix the regressions from 59d85a2. This was tested on zsh 5.7.1 (x86_64-apple-darwin19.0). Suggested-by: Felipe Contreras <[email protected]> Signed-off-by: David Aguilar <[email protected]> Acked-by: Felipe Contreras <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent ed125c4 commit 0b18023

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

contrib/completion/git-completion.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1306,7 +1306,7 @@ __git_count_arguments ()
13061306
local word i c=0
13071307

13081308
# Skip "git" (first argument)
1309-
for ((i="$__git_cmd_idx"; i < ${#words[@]}; i++)); do
1309+
for ((i=$__git_cmd_idx; i < ${#words[@]}; i++)); do
13101310
word="${words[i]}"
13111311

13121312
case "$word" in

contrib/completion/git-completion.zsh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ __git_zsh_main ()
251251
done
252252
;;
253253
(arg)
254-
local command="${words[1]}" __git_dir
254+
local command="${words[1]}" __git_dir __git_cmd_idx=1
255255

256256
if (( $+opt_args[--bare] )); then
257257
__git_dir='.'

0 commit comments

Comments
 (0)