Skip to content

Commit 0bc85a7

Browse files
dschoGit for Windows Build Agent
authored andcommitted
mingw: bump the minimum Windows version to Vista
Quite some time ago, a last plea to the XP users out there who want to see Windows XP support in Git for Windows, asking them to get engaged and help, vanished into the depths of the universe. It is time to codify the ascent by the "silent majority" of XP users, and mark the minimum Windows version required for Git for Windows as Windows Vista. This, incidentally, lets us use quite a few nice new APIs. This also means that we no longer need the inet_pton() and inet_ntop() emulation, and we no longer need to do the PROC_ADDR dance with the `CreateSymbolicLinkW()` function, either. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 3d9f867 commit 0bc85a7

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

compat/mingw.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,6 @@ int mingw_core_config(const char *var, const char *value, void *cb)
274274
}
275275

276276
static DWORD symlink_file_flags = 0, symlink_directory_flags = 1;
277-
DECLARE_PROC_ADDR(kernel32.dll, BOOLEAN, CreateSymbolicLinkW, LPCWSTR, LPCWSTR, DWORD);
278277

279278
enum phantom_symlink_result {
280279
PHANTOM_SYMLINK_RETRY,
@@ -2722,7 +2721,7 @@ int symlink(const char *target, const char *link)
27222721
int len;
27232722

27242723
/* fail if symlinks are disabled or API is not supported (WinXP) */
2725-
if (!has_symlinks || !INIT_PROC_ADDR(CreateSymbolicLinkW)) {
2724+
if (!has_symlinks) {
27262725
errno = ENOSYS;
27272726
return -1;
27282727
}

config.mak.uname

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -417,8 +417,6 @@ ifeq ($(uname_S),Windows)
417417
NO_GETTEXT = YesPlease
418418
NO_PYTHON = YesPlease
419419
ETAGS_TARGET = ETAGS
420-
NO_INET_PTON = YesPlease
421-
NO_INET_NTOP = YesPlease
422420
NO_POSIX_GOODIES = UnfortunatelyYes
423421
NATIVE_CRLF = YesPlease
424422
DEFAULT_HELP_FORMAT = html
@@ -587,8 +585,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
587585
NO_REGEX = YesPlease
588586
NO_PYTHON = YesPlease
589587
ETAGS_TARGET = ETAGS
590-
NO_INET_PTON = YesPlease
591-
NO_INET_NTOP = YesPlease
592588
NO_POSIX_GOODIES = UnfortunatelyYes
593589
DEFAULT_HELP_FORMAT = html
594590
COMPAT_CFLAGS += -DNOGDI -Icompat -Icompat/win32

git-compat-util.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156

157157
#if defined(WIN32) && !defined(__CYGWIN__) /* Both MinGW and MSVC */
158158
# if !defined(_WIN32_WINNT)
159-
# define _WIN32_WINNT 0x0502
159+
# define _WIN32_WINNT 0x0600
160160
# endif
161161
#define WIN32_LEAN_AND_MEAN /* stops windows.h including winsock.h */
162162
#include <winsock2.h>

0 commit comments

Comments
 (0)