Skip to content

Commit 0d322ea

Browse files
kbleesdscho
authored andcommitted
Win32: implement basic symlink() functionality (file symlinks only)
Implement symlink() that always creates file symlinks. Fails with ENOSYS if symlinks are disabled or unsupported. Note: CreateSymbolicLinkW() was introduced with symlink support in Windows Vista. For compatibility with Windows XP, we need to load it dynamically and fail gracefully if it isnt's available. Signed-off-by: Karsten Blees <[email protected]>
1 parent 5e3b4b5 commit 0d322ea

File tree

2 files changed

+32
-2
lines changed

2 files changed

+32
-2
lines changed

compat/mingw.c

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,9 @@ static int retry_ask_yes_no(int *tries, const char *format, ...)
230230
return result;
231231
}
232232

233+
234+
DECLARE_PROC_ADDR(kernel32.dll, BOOL, CreateSymbolicLinkW, LPCWSTR, LPCWSTR, DWORD);
235+
233236
/* Normalizes NT paths as returned by some low-level APIs. */
234237
static wchar_t *normalize_ntpath(wchar_t *wbuf)
235238
{
@@ -2082,6 +2085,34 @@ int link(const char *oldpath, const char *newpath)
20822085
return 0;
20832086
}
20842087

2088+
int symlink(const char *target, const char *link)
2089+
{
2090+
wchar_t wtarget[MAX_LONG_PATH], wlink[MAX_LONG_PATH];
2091+
int len;
2092+
2093+
/* fail if symlinks are disabled or API is not supported (WinXP) */
2094+
if (!has_symlinks || !INIT_PROC_ADDR(CreateSymbolicLinkW)) {
2095+
errno = ENOSYS;
2096+
return -1;
2097+
}
2098+
2099+
if ((len = xutftowcs_long_path(wtarget, target)) < 0
2100+
|| xutftowcs_long_path(wlink, link) < 0)
2101+
return -1;
2102+
2103+
/* convert target dir separators to backslashes */
2104+
while (len--)
2105+
if (wtarget[len] == '/')
2106+
wtarget[len] = '\\';
2107+
2108+
/* create file symlink */
2109+
if (!CreateSymbolicLinkW(wlink, wtarget, 0)) {
2110+
errno = err_win_to_posix(GetLastError());
2111+
return -1;
2112+
}
2113+
return 0;
2114+
}
2115+
20852116
#ifndef _WINNT_H
20862117
/*
20872118
* The REPARSE_DATA_BUFFER structure is defined in the Windows DDK (in

compat/mingw.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,6 @@ struct utsname {
110110
* trivial stubs
111111
*/
112112

113-
static inline int symlink(const char *oldpath, const char *newpath)
114-
{ errno = ENOSYS; return -1; }
115113
static inline int fchmod(int fildes, mode_t mode)
116114
{ errno = ENOSYS; return -1; }
117115
#ifndef __MINGW64_VERSION_MAJOR
@@ -202,6 +200,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out);
202200
int sigaction(int sig, struct sigaction *in, struct sigaction *out);
203201
int link(const char *oldpath, const char *newpath);
204202
int uname(struct utsname *buf);
203+
int symlink(const char *target, const char *link);
205204
int readlink(const char *path, char *buf, size_t bufsiz);
206205

207206
/*

0 commit comments

Comments
 (0)