Skip to content

Commit 11fd266

Browse files
committed
Merge 'git-wrapper' into HEAD
Use msysGit's `git-wrapper` instead of the builtins. This works around two issues: - when the file system does not allow hard links, we would waste over 800 megabyte by having 109 copies of a multi-megabyte executable - even when the file system allows hard links, the Windows Explorer counts the disk usage as if it did not. Many users complained about Git for Windows using too much space (when it actually did not). We can easily avoid those user complaints by merging this branch. Signed-off-by: Johannes Schindelin <[email protected]>
2 parents ec69f80 + 45607bb commit 11fd266

File tree

3 files changed

+538
-8
lines changed

3 files changed

+538
-8
lines changed

Makefile

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1678,11 +1678,17 @@ version.sp version.s version.o: EXTRA_CPPFLAGS = \
16781678
'-DGIT_VERSION="$(GIT_VERSION)"' \
16791679
'-DGIT_USER_AGENT=$(GIT_USER_AGENT_CQ_SQ)'
16801680

1681+
ifeq (,$(BUILT_IN_WRAPPER))
16811682
$(BUILT_INS): git$X
16821683
$(QUIET_BUILT_IN)$(RM) $@ && \
16831684
ln $< $@ 2>/dev/null || \
16841685
ln -s $< $@ 2>/dev/null || \
16851686
cp $< $@
1687+
else
1688+
$(BUILT_INS): $(BUILT_IN_WRAPPER)
1689+
$(QUIET_BUILT_IN)$(RM) $@ && \
1690+
cp $< $@
1691+
endif
16861692

16871693
common-cmds.h: ./generate-cmdlist.sh command-list.txt
16881694

@@ -2246,6 +2252,24 @@ profile-install: profile
22462252
profile-fast-install: profile-fast
22472253
$(MAKE) install
22482254

2255+
ifeq (,$(BUILT_IN_WRAPPER))
2256+
LN_OR_CP_BUILT_IN_BINDIR = \
2257+
test -z "$(NO_INSTALL_HARDLINKS)" && \
2258+
ln "$$bindir/git$X" "$$bindir/$$p" 2>/dev/null || \
2259+
ln -s "git$X" "$$bindir/$$p" 2>/dev/null || \
2260+
cp "$$bindir/git$X" "$$bindir/$$p" || exit;
2261+
LN_OR_CP_BUILT_IN_EXECDIR = \
2262+
test -z "$(NO_INSTALL_HARDLINKS)" && \
2263+
ln "$$execdir/git$X" "$$execdir/$$p" 2>/dev/null || \
2264+
ln -s "git$X" "$$execdir/$$p" 2>/dev/null || \
2265+
cp "$$execdir/git$X" "$$execdir/$$p" || exit;
2266+
else
2267+
LN_OR_CP_BUILT_IN_BINDIR = \
2268+
cp "$(BUILT_IN_WRAPPER)" "$$bindir/$$p" || exit;
2269+
LN_OR_CP_BUILT_IN_EXECDIR = \
2270+
cp "$(BUILT_IN_WRAPPER)" "$$execdir/$$p" || exit;
2271+
endif
2272+
22492273
install: all
22502274
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'
22512275
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
@@ -2284,17 +2308,11 @@ endif
22842308
} && \
22852309
for p in $(filter $(install_bindir_programs),$(BUILT_INS)); do \
22862310
$(RM) "$$bindir/$$p" && \
2287-
test -z "$(NO_INSTALL_HARDLINKS)" && \
2288-
ln "$$bindir/git$X" "$$bindir/$$p" 2>/dev/null || \
2289-
ln -s "git$X" "$$bindir/$$p" 2>/dev/null || \
2290-
cp "$$bindir/git$X" "$$bindir/$$p" || exit; \
2311+
$(LN_OR_CP_BUILT_IN_BINDIR) \
22912312
done && \
22922313
for p in $(BUILT_INS); do \
22932314
$(RM) "$$execdir/$$p" && \
2294-
test -z "$(NO_INSTALL_HARDLINKS)" && \
2295-
ln "$$execdir/git$X" "$$execdir/$$p" 2>/dev/null || \
2296-
ln -s "git$X" "$$execdir/$$p" 2>/dev/null || \
2297-
cp "$$execdir/git$X" "$$execdir/$$p" || exit; \
2315+
$(LN_OR_CP_BUILT_IN_EXECDIR) \
22982316
done && \
22992317
remote_curl_aliases="$(REMOTE_CURL_ALIASES)" && \
23002318
for p in $$remote_curl_aliases; do \

0 commit comments

Comments
 (0)