Skip to content

Commit 1309d0d

Browse files
kbleesGit for Windows Build Agent
authored andcommitted
Win32: make the lstat implementation pluggable
Emulating the POSIX lstat API on Windows via GetFileAttributes[Ex] is quite slow. Windows operating system APIs seem to be much better at scanning the status of entire directories than checking single files. A caching implementation may improve performance by bulk-reading entire directories or reusing data obtained via opendir / readdir. Make the lstat implementation pluggable so that it can be switched at runtime, e.g. based on a config option. Signed-off-by: Karsten Blees <[email protected]>
1 parent 9bacab2 commit 1309d0d

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

compat/mingw.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,8 @@ static int do_stat_internal(int follow, const char *file_name, struct stat *buf)
651651
return do_lstat(follow, alt_name, buf);
652652
}
653653

654+
int (*lstat)(const char *file_name, struct stat *buf) = mingw_lstat;
655+
654656
int mingw_lstat(const char *file_name, struct stat *buf)
655657
{
656658
return do_stat_internal(0, file_name, buf);

compat/mingw.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ int mingw_fstat(int fd, struct stat *buf);
365365
#ifdef lstat
366366
#undef lstat
367367
#endif
368-
#define lstat mingw_lstat
368+
extern int (*lstat)(const char *file_name, struct stat *buf);
369369

370370
#ifndef _stati64
371371
# define _stati64(x,y) mingw_stat(x,y)

0 commit comments

Comments
 (0)