Skip to content

Commit 142faef

Browse files
kbleesdscho
authored andcommitted
Win32: make the lstat implementation pluggable
Emulating the POSIX lstat API on Windows via GetFileAttributes[Ex] is quite slow. Windows operating system APIs seem to be much better at scanning the status of entire directories than checking single files. A caching implementation may improve performance by bulk-reading entire directories or reusing data obtained via opendir / readdir. Make the lstat implementation pluggable so that it can be switched at runtime, e.g. based on a config option. Signed-off-by: Karsten Blees <[email protected]>
1 parent 4345706 commit 142faef

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

compat/mingw.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -632,6 +632,8 @@ static int do_stat_internal(int follow, const char *file_name, struct stat *buf)
632632
return do_lstat(follow, alt_name, buf);
633633
}
634634

635+
int (*lstat)(const char *file_name, struct stat *buf) = mingw_lstat;
636+
635637
int mingw_lstat(const char *file_name, struct stat *buf)
636638
{
637639
return do_stat_internal(0, file_name, buf);

compat/mingw.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ int mingw_fstat(int fd, struct stat *buf);
357357
#ifdef lstat
358358
#undef lstat
359359
#endif
360-
#define lstat mingw_lstat
360+
extern int (*lstat)(const char *file_name, struct stat *buf);
361361

362362
#ifndef _stati64
363363
# define _stati64(x,y) mingw_stat(x,y)

0 commit comments

Comments
 (0)