Skip to content

Commit 1689e3b

Browse files
committed
Merge branch 'vn/reset-deleted-ita' into pu
"git reset HEAD [<pathspec>]" did not reset an empty file that was added with the intent-to-add bit. * vn/reset-deleted-ita: reset: unstage empty deleted ita files
2 parents 2d128cd + bd9e17d commit 1689e3b

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

builtin/reset.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ static int read_from_tree(const struct pathspec *pathspec,
164164
opt.format_callback_data = &intent_to_add;
165165
opt.flags.override_submodule_config = 1;
166166
opt.repo = the_repository;
167+
opt.ita_invisible_in_index = 1;
167168

168169
if (do_diff_cache(tree_oid, &opt))
169170
return 1;

t/t7102-reset.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -566,4 +566,15 @@ test_expect_success 'reset --mixed sets up work tree' '
566566
test_must_be_empty actual
567567
'
568568

569+
test_expect_success 'reset --mixed adds deleted intent-to-add file back to index' '
570+
echo "nonempty" >nonempty &&
571+
>empty &&
572+
git add nonempty empty &&
573+
git commit -m "create files to be deleted" &&
574+
git rm --cached nonempty empty &&
575+
git add -N nonempty empty &&
576+
git reset HEAD nonempty empty &&
577+
git diff --cached --exit-code HEAD
578+
'
579+
569580
test_done

0 commit comments

Comments
 (0)