Additional error checks for issuing the windows.appendAtomically warning (#4528)

dscho · Git for Windows Build Agent · commit 16f68c85e938 · 2023-12-11T22:11:24.000Z
Another (hopefully clean) PR for showing the error warning about atomic
append on windows after failure on APFS, which returns EBADF not EINVAL.

Signed-off-by: David Lomas &lt;dl3@pale-eds.co.uk&gt;
diff --git a/compat/mingw.c b/compat/mingw.c
@@ -719,7 +719,7 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
 {
 	ssize_t result = write(fd, buf, len);
 
-	if (result < 0 && errno == EINVAL && buf) {
+	if (result < 0 && (errno == EINVAL || errno == EBADF) && buf) {
 		/* check if fd is a pipe */
 		HANDLE h = (HANDLE) _get_osfhandle(fd);
 		if (GetFileType(h) == FILE_TYPE_PIPE)

Original file line number	Diff line number	Diff line change
`@@ -719,7 +719,7 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)`
`719`	`719`	`{`
`720`	`720`	`ssize_t result = write(fd, buf, len);`
`721`	`721`
`722`		`- if (result < 0 && errno == EINVAL && buf) {`
	`722`	`+ if (result < 0 && (errno == EINVAL \|\| errno == EBADF) && buf) {`
`723`	`723`	`/* check if fd is a pipe */`
`724`	`724`	`HANDLE h = (HANDLE) _get_osfhandle(fd);`
`725`	`725`	`if (GetFileType(h) == FILE_TYPE_PIPE)`