Skip to content

Commit 1edc9f6

Browse files
Philip OakleyGit for Windows Build Agent
authored andcommitted
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
1 parent cd49455 commit 1edc9f6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-gui/lib/choose_repository.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ proc _get_recentrepos {} {
247247

248248
proc _unset_recentrepo {p} {
249249
regsub -all -- {([()\[\]{}\.^$+*?\\])} $p {\\\1} p
250-
git config --global --unset gui.recentrepo "^$p\$"
250+
git config --global --unset-all gui.recentrepo "^$p\$"
251251
load_config 1
252252
}
253253

0 commit comments

Comments
 (0)