Skip to content

Commit 213958f

Browse files
committed
ci(linux32): add a note about Actions that must not be updated
The Docker container used by the `linux32` job comes without Node.js, and therefore the `actions/checkout` and `actions/upload-artifact` Actions cannot be upgraded to the latest versions (because they use Node.js). One time too many, I accidentally tried to update them, where `actions/checkout` at least fails immediately, but the `actions/upload-artifact` step is only used when any test fails, and therefore the CI run usually passes even though that Action was updated to a version that is incompatible with the Docker container in which this job runs. So let's add a big fat warning, mainly for my own benefit, to avoid running into the very same issue over and over again. Backported-from: 20e0ff8 (ci(linux32): add a note about Actions that must not be updated, 2024-02-11) Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 7e1bcc8 commit 213958f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ jobs:
321321
steps:
322322
- uses: actions/checkout@v4
323323
if: matrix.vector.jobname != 'linux32'
324-
- uses: actions/checkout@v1
324+
- uses: actions/checkout@v1 # cannot be upgraded because Node.js Actions aren't supported in this container
325325
if: matrix.vector.jobname == 'linux32'
326326
- run: ci/install-docker-dependencies.sh
327327
- run: ci/run-build-and-tests.sh
@@ -335,7 +335,7 @@ jobs:
335335
path: ${{env.FAILED_TEST_ARTIFACTS}}
336336
- name: Upload failed tests' directories
337337
if: failure() && env.FAILED_TEST_ARTIFACTS != '' && matrix.vector.jobname == 'linux32'
338-
uses: actions/upload-artifact@v1
338+
uses: actions/upload-artifact@v1 # cannot be upgraded because Node.js Actions aren't supported in this container
339339
with:
340340
name: failed-tests-${{matrix.vector.jobname}}
341341
path: ${{env.FAILED_TEST_ARTIFACTS}}

0 commit comments

Comments
 (0)