Skip to content

Commit 2372d65

Browse files
committed
fixup! gitk: work around the command line limit on Windows
This was an ugly hack, and in preparation for fixing it the right way, we revert this hack. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 42c041a commit 2372d65

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

gitk-git/gitk

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10177,19 +10177,7 @@ proc getallcommits {} {
1017710177
}
1017810178
}
1017910179
if {$ids ne {}} {
10180-
set cmd [concat $cmd $ids]
10181-
# The maximum command line length for the CreateProcess function is 32767 characters, see
10182-
# http://blogs.msdn.com/oldnewthing/archive/2003/12/10/56028.aspx
10183-
# Be a little conservative in case Tcl adds some more stuff to the command line we do not
10184-
# know about and truncate the command line at a SHA1-boundary below 32000 characters.
10185-
if {[tk windowingsystem] == "win32" &&
10186-
[string length $cmd] > 32000} {
10187-
set ndx [string last " " $cmd 32000]
10188-
if {$ndx != -1} {
10189-
set cmd [string range $cmd 0 $ndx]
10190-
}
10191-
}
10192-
set fd [open $cmd r]
10180+
set fd [open [concat $cmd $ids] r]
1019310181
fconfigure $fd -blocking 0
1019410182
incr allcommits
1019510183
nowbusy allcommits

0 commit comments

Comments
 (0)