Skip to content

Commit 251eb07

Browse files
kbleesdscho
authored andcommitted
Win32: make the lstat implementation pluggable
Emulating the POSIX lstat API on Windows via GetFileAttributes[Ex] is quite slow. Windows operating system APIs seem to be much better at scanning the status of entire directories than checking single files. A caching implementation may improve performance by bulk-reading entire directories or reusing data obtained via opendir / readdir. Make the lstat implementation pluggable so that it can be switched at runtime, e.g. based on a config option. Signed-off-by: Karsten Blees <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 6aa4b9c commit 251eb07

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

compat/mingw/compat-util.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1007,6 +1007,8 @@ static int do_stat_internal(int follow, const char *file_name, struct stat *buf)
10071007
return do_lstat(follow, alt_name, buf);
10081008
}
10091009

1010+
int (*lstat)(const char *file_name, struct stat *buf) = mingw_lstat;
1011+
10101012
static int get_file_info_by_handle(HANDLE hnd, struct stat *buf)
10111013
{
10121014
BY_HANDLE_FILE_INFORMATION fdata;

compat/mingw/posix.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ int mingw_fstat(int fd, struct stat *buf);
404404
#ifdef lstat
405405
#undef lstat
406406
#endif
407-
#define lstat mingw_lstat
407+
extern int (*lstat)(const char *file_name, struct stat *buf);
408408

409409

410410
int mingw_utime(const char *file_name, const struct utimbuf *times);

0 commit comments

Comments
 (0)