Merge branch 'dscho/gcc-8-gfw-fixups'

Turns out that my fix was *not* good, as I cast a function pointer to a
data pointer, and then back to a different function pointer, in an
attempt to shut up GCC 8.x.

But a cast between a function pointer and a data pointer is actually not
allowed. It just happens to work on many CPUs, but maybe in the future
we will all have CPUs that are safer and really have separate memory for
code than for data (which would however break JITs).

In any case, the cast's purpose was to avoid the warning by saying "yes,
we know, this is a different pointer, but we know what we're doing,
let's cast to `(void *)` as a generic pointer and then further to the
one we know is the correct type". This works for data pointers of
different types.

For function pointers, the equivalent of `void *` is `void (*)(void)`.
So let's use that instead.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

compat/poll/poll.c

@@ -149,7 +149,7 @@ win32_compute_revents (HANDLE h, int *p_sought)
     case FILE_TYPE_PIPE:
       if (!once_only)
 	{
-	  NtQueryInformationFile = (PNtQueryInformationFile)(void *)
+	  NtQueryInformationFile = (PNtQueryInformationFile)(void (*)(void))
 	    GetProcAddress (GetModuleHandleA ("ntdll.dll"),
 			    "NtQueryInformationFile");
 	  once_only = TRUE;

compat/win32/exit-process.h

@@ -130,7 +130,8 @@ static int exit_process(HANDLE process, int exit_code)
 			HINSTANCE kernel32 = GetModuleHandleA("kernel32");
 			if (!kernel32)
 				die("BUG: cannot find kernel32");
-			exit_process_address = (LPTHREAD_START_ROUTINE)(void *)
+			exit_process_address =
+				(LPTHREAD_START_ROUTINE)(void (*)(void))
 				GetProcAddress(kernel32, "ExitProcess");
 			initialized = 1;
 		}