Skip to content

Commit 28cb707

Browse files
patthoytsgitster
authored andcommitted
gitk: fix tabbed preferences construction when using tcl 8.4
In 8.5 the incr command creates the target variable if it does not exist but in 8.4 using incr on a non-existing variable raises an error. Ensure we have created our counter variable when creating the tabbed dialog for non-themed preferences. Reported-by: Ramsay Jones <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b2b76d1 commit 28cb707

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

gitk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11012,6 +11012,7 @@ proc doprefs {} {
1101211012
lappend pages [prefspage_general $notebook] [mc "General"]
1101311013
lappend pages [prefspage_colors $notebook] [mc "Colors"]
1101411014
lappend pages [prefspage_fonts $notebook] [mc "Fonts"]
11015+
set col 0
1101511016
foreach {page title} $pages {
1101611017
if {$use_notebook} {
1101711018
$notebook add $page -text $title

0 commit comments

Comments
 (0)