Skip to content

Commit 2b0e14f

Browse files
phil-blaingitster
authored andcommitted
ci: do not cancel all jobs of a matrix if one fails
The CI/PR GitHub Actions workflow uses the 'matrix' strategy for the "windows-test", "vs-test", "regular" and "dockerized" jobs. The default behaviour of GitHub Actions is to cancel all in-progress jobs in a matrix if one of the job of the matrix fails [1]. This is not ideal as a failure early in a job, like during installation of the build/test dependencies on a specific platform, leads to the cancellation of all other jobs in the matrix. Set the 'fail-fast' variable to 'false' for all four matrix jobs in the workflow. [1] https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast Signed-off-by: Philippe Blain <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 71ca53e commit 2b0e14f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ jobs:
123123
runs-on: windows-latest
124124
needs: [windows-build]
125125
strategy:
126+
fail-fast: false
126127
matrix:
127128
nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
128129
steps:
@@ -227,6 +228,7 @@ jobs:
227228
runs-on: windows-latest
228229
needs: [vs-build, windows-build]
229230
strategy:
231+
fail-fast: false
230232
matrix:
231233
nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
232234
steps:
@@ -272,6 +274,7 @@ jobs:
272274
needs: ci-config
273275
if: needs.ci-config.outputs.enabled == 'yes'
274276
strategy:
277+
fail-fast: false
275278
matrix:
276279
vector:
277280
- jobname: linux-clang
@@ -309,6 +312,7 @@ jobs:
309312
needs: ci-config
310313
if: needs.ci-config.outputs.enabled == 'yes'
311314
strategy:
315+
fail-fast: false
312316
matrix:
313317
vector:
314318
- jobname: linux-musl

0 commit comments

Comments
 (0)