Skip to content

Commit 2be9450

Browse files
bk2204gitster
authored andcommitted
submodule: fix confusing variable name
cmd_summary reads the output of git diff, but reads in the submodule path into a variable called name. Since this variable does not contain the name of the submodule, but the path, rename it to be clearer what data it actually holds. Signed-off-by: Brian M. Carlson <[email protected]> Acked-by: Jens Lehmann <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4d06473 commit 2be9450

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

git-submodule.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,13 +1032,13 @@ cmd_summary() {
10321032
# Get modified modules cared by user
10331033
modules=$(git $diff_cmd $cached --ignore-submodules=dirty --raw $head -- "$@" |
10341034
sane_egrep '^:([0-7]* )?160000' |
1035-
while read mod_src mod_dst sha1_src sha1_dst status name
1035+
while read mod_src mod_dst sha1_src sha1_dst status sm_path
10361036
do
10371037
# Always show modules deleted or type-changed (blob<->module)
1038-
test $status = D -o $status = T && echo "$name" && continue
1038+
test $status = D -o $status = T && echo "$sm_path" && continue
10391039
# Also show added or modified modules which are checked out
1040-
GIT_DIR="$name/.git" git-rev-parse --git-dir >/dev/null 2>&1 &&
1041-
echo "$name"
1040+
GIT_DIR="$sm_path/.git" git-rev-parse --git-dir >/dev/null 2>&1 &&
1041+
echo "$sm_path"
10421042
done
10431043
)
10441044

0 commit comments

Comments
 (0)