Skip to content

Commit 2fbd29a

Browse files
committed
fixup! mingw: Embed a manifest to trick UAC into Doing The Right Thing
Also mark the Git executable as compatible with Windows Vista or later (at the time of writing, the latest version is Windows 10) because otherwise the manifest would be ignored on Windows 8.1 or later. This fixes #258. In Git for Windows 2.x' context, we technically do not need to embed the <compatibility> section ourselves because MSys2's mingw-w64-<arch>-windows-default-manifest package already contains it, starting with version 6.4-2 (release on or after July 10th, 2015). However, not all Git developers use MSys2 on Windows (doubtlessly in an attempt to make the life of Git for Windows' maintainer harder than necessary), therefore we still need to add that section explicitly. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 41980ef commit 2fbd29a

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

compat/win32/git.manifest

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,18 @@
88
</requestedPrivileges>
99
</security>
1010
</trustInfo>
11+
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
12+
<application>
13+
<!-- Windows Vista -->
14+
<supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
15+
<!-- Windows 7 -->
16+
<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
17+
<!-- Windows 8 -->
18+
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
19+
<!-- Windows 8.1 -->
20+
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
21+
<!-- Windows 10 -->
22+
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
23+
</application>
24+
</compatibility>
1125
</assembly>

0 commit comments

Comments
 (0)