refs/files-backend: remove unused open mode parameter

rscharfe · gitster · commit 35cf94eaf6c8 · 2021-09-09T17:40:28.000-07:00
We only need to provide a mode if we are willing to let open(2) create
the file, which is not the case here, so drop the unnecessary parameter.

Signed-off-by: René Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs/files-backend.c b/refs/files-backend.c
@@ -1569,7 +1569,7 @@ static int log_ref_setup(struct files_ref_store *refs,
 			goto error;
 		}
 	} else {
-		*logfd = open(logfile, O_APPEND | O_WRONLY, 0666);
+		*logfd = open(logfile, O_APPEND | O_WRONLY);
 		if (*logfd < 0) {
 			if (errno == ENOENT || errno == EISDIR) {
 				/*

Original file line number	Diff line number	Diff line change
`@@ -1569,7 +1569,7 @@ static int log_ref_setup(struct files_ref_store *refs,`
`1569`	`1569`	`goto error;`
`1570`	`1570`	`}`
`1571`	`1571`	`} else {`
`1572`		`- *logfd = open(logfile, O_APPEND \| O_WRONLY, 0666);`
	`1572`	`+ *logfd = open(logfile, O_APPEND \| O_WRONLY);`
`1573`	`1573`	`if (*logfd < 0) {`
`1574`	`1574`	`if (errno == ENOENT \|\| errno == EISDIR) {`
`1575`	`1575`	`/*`