Skip to content

Commit 3c775cb

Browse files
dschoGit for Windows Build Agent
authored andcommitted
t1300: mark all test cases with funny filenames as !MINGW
On Windows, it is impossible to create a file whose name contains a quote character. We already excluded test cases using such files from running on Windows when git.exe itself was tested. However, we still had two test cases that try to create such a file, and redirect stdin from such a file, respectively. This *seems* to work in Git for Windows' Bash due to an obscure feature inherited from Cygwin: illegal filename characters are simply mapped into/from a private UTF-8 page. Pure Win32 programs (such as git.exe) *still* cannot work with those files, of course, but at least Unix shell scripts pretend to be able to. This entire strategy breaks down when switching to any Unix shell lacking support for that private UTF-8 page trick, e.g. BusyBox-w32's ash. So let's just exclude test cases that test whether the Unix shell can redirect to/from files with "funny names" those from running on Windows, too. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent fbae0a6 commit 3c775cb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t1300-config.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1709,7 +1709,7 @@ test_expect_success '--show-origin getting a single key' '
17091709
test_cmp expect output
17101710
'
17111711

1712-
test_expect_success 'set up custom config file' '
1712+
test_expect_success !MINGW 'set up custom config file' '
17131713
CUSTOM_CONFIG_FILE="file\" (dq) and spaces.conf" &&
17141714
cat >"$CUSTOM_CONFIG_FILE" <<-\EOF
17151715
[user]
@@ -1725,7 +1725,7 @@ test_expect_success !MINGW '--show-origin escape special file name characters' '
17251725
test_cmp expect output
17261726
'
17271727

1728-
test_expect_success '--show-origin stdin' '
1728+
test_expect_success !MINGW '--show-origin stdin' '
17291729
cat >expect <<-\EOF &&
17301730
standard input: user.custom=true
17311731
EOF

0 commit comments

Comments
 (0)