mailinfo: remove misguided assert() statement

The idea of this assert() statement was to test, in debug mode, that the
check_header() function actually finds anything.

However, enclosing the call to that function in an assert() makes it fair
game for smart compilers *to skip the call in release mode*. Which is not
at all what we want here.

Remember: just because it works with GCC does not mean that it is correct.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

mailinfo.c

@@ -710,7 +710,7 @@ static void flush_inbody_header_accum(struct mailinfo *mi)
 {
 	if (!mi->inbody_header_accum.len)
 		return;
-	assert(check_header(mi, &mi->inbody_header_accum, mi->s_hdr_data, 0));
+	check_header(mi, &mi->inbody_header_accum, mi->s_hdr_data, 0);
 	strbuf_reset(&mi->inbody_header_accum);
 }