Skip to content

Commit 479eaa8

Browse files
abbaadgitster
authored andcommitted
http-push.c: make CURLOPT_IOCTLDATA a usable pointer
Fixes a small bug affecting push to remotes which use some sort of multi-pass authentication. In particular the bug affected SabreDAV as configured by Box.com [1]. It must be a weird server configuration for the bug to have survived this long. Someone should write a test for it. [1] http://marc.info/?l=git&m=140460482604482 Signed-off-by: Abbaad Haider <[email protected]> Reviewed-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 45067fc commit 479eaa8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

http-push.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ static void curl_setup_http(CURL *curl, const char *url,
200200
curl_easy_setopt(curl, CURLOPT_READFUNCTION, fread_buffer);
201201
#ifndef NO_CURL_IOCTL
202202
curl_easy_setopt(curl, CURLOPT_IOCTLFUNCTION, ioctl_buffer);
203-
curl_easy_setopt(curl, CURLOPT_IOCTLDATA, &buffer);
203+
curl_easy_setopt(curl, CURLOPT_IOCTLDATA, buffer);
204204
#endif
205205
curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, write_fn);
206206
curl_easy_setopt(curl, CURLOPT_NOBODY, 0);

0 commit comments

Comments
 (0)