Skip to content

Commit 4a5ec7d

Browse files
dschogitster
authored andcommitted
SKIP_DASHED_BUILT_INS: respect config.mak
When `SKIP_DASHED_BUILT_INS` is specified in `config.mak`, the dashed form of the built-ins was still generated. By moving the `SKIP_DASHED_BUILT_INS` handling after `config.mak` was read, this can be avoided. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 898f807 commit 4a5ec7d

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

Makefile

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -775,20 +775,6 @@ BUILT_INS += git-status$X
775775
BUILT_INS += git-switch$X
776776
BUILT_INS += git-whatchanged$X
777777

778-
# what 'all' will build and 'install' will install in gitexecdir,
779-
# excluding programs for built-in commands
780-
ALL_PROGRAMS = $(PROGRAMS) $(SCRIPTS)
781-
ALL_COMMANDS_TO_INSTALL = $(ALL_PROGRAMS)
782-
ifeq (,$(SKIP_DASHED_BUILT_INS))
783-
ALL_COMMANDS_TO_INSTALL += $(BUILT_INS)
784-
else
785-
# git-upload-pack, git-receive-pack and git-upload-archive are special: they
786-
# are _expected_ to be present in the `bin/` directory in their dashed form.
787-
ALL_COMMANDS_TO_INSTALL += git-receive-pack$(X)
788-
ALL_COMMANDS_TO_INSTALL += git-upload-archive$(X)
789-
ALL_COMMANDS_TO_INSTALL += git-upload-pack$(X)
790-
endif
791-
792778
# what 'all' will build but not install in gitexecdir
793779
OTHER_PROGRAMS = git$X
794780

@@ -1220,6 +1206,20 @@ ifdef DEVELOPER
12201206
include config.mak.dev
12211207
endif
12221208

1209+
# what 'all' will build and 'install' will install in gitexecdir,
1210+
# excluding programs for built-in commands
1211+
ALL_PROGRAMS = $(PROGRAMS) $(SCRIPTS)
1212+
ALL_COMMANDS_TO_INSTALL = $(ALL_PROGRAMS)
1213+
ifeq (,$(SKIP_DASHED_BUILT_INS))
1214+
ALL_COMMANDS_TO_INSTALL += $(BUILT_INS)
1215+
else
1216+
# git-upload-pack, git-receive-pack and git-upload-archive are special: they
1217+
# are _expected_ to be present in the `bin/` directory in their dashed form.
1218+
ALL_COMMANDS_TO_INSTALL += git-receive-pack$(X)
1219+
ALL_COMMANDS_TO_INSTALL += git-upload-archive$(X)
1220+
ALL_COMMANDS_TO_INSTALL += git-upload-pack$(X)
1221+
endif
1222+
12231223
ALL_CFLAGS = $(DEVELOPER_CFLAGS) $(CPPFLAGS) $(CFLAGS)
12241224
ALL_LDFLAGS = $(LDFLAGS)
12251225

0 commit comments

Comments
 (0)