Skip to content

Commit 4ecbc65

Browse files
jrngitster
authored andcommitted
Makefile: make ppc/sha1ppc.o depend on GIT-CFLAGS
The %.o: %.S pattern rule should depend on GIT-CFLAGS to avoid trouble when ALL_CFLAGS changes. The pattern only applies to one file (ppc/sha1ppc.S) and that file does not use any #ifdefs, so leaving the dependency out is probably harmless. Nevertheless, it is safer to include the dependency in case future code's behavior does depend on the build flags. Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent bd757c1 commit 4ecbc65

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1635,7 +1635,7 @@ git.o git.spec \
16351635
$(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $<
16361636
%.s: %.c GIT-CFLAGS
16371637
$(QUIET_CC)$(CC) -S $(ALL_CFLAGS) $<
1638-
%.o: %.S
1638+
%.o: %.S GIT-CFLAGS
16391639
$(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $<
16401640

16411641
exec_cmd.o: exec_cmd.c GIT-CFLAGS

0 commit comments

Comments
 (0)