Skip to content

Commit 52bd3e4

Browse files
roblubgitster
authored andcommitted
gitweb: correctly store previous rev in javascript-actions mode
Without this change, the setting $feature{'javascript-actions'}{'default'} = [1]; in gitweb.conf breaks gitweb's blame page: clicking on line numbers displayed in the second column on the page has no effect. For comparison, with javascript-actions disabled, clicking on line numbers loads the previous version of the line. Addresses https://bugs.debian.org/741883. Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Robert Luberda <[email protected]> Acked-by: Jakub Narębski <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 5fa0f52 commit 52bd3e4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gitweb/static/js/blame_incremental.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ function processBlameLines(lines) {
484484
case 'previous':
485485
curCommit.nprevious++;
486486
// store only first 'previous' header
487-
if (!'previous' in curCommit) {
487+
if (!('previous' in curCommit)) {
488488
var parts = data.split(' ', 2);
489489
curCommit.previous = parts[0];
490490
curCommit.file_parent = unquote(parts[1]);

0 commit comments

Comments
 (0)