Skip to content

Commit 52fecab

Browse files
committed
merge: extract prepare_merge_message() logic out
Signed-off-by: Junio C Hamano <[email protected]>
1 parent 018b3fb commit 52fecab

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

builtin/merge.c

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,6 +1076,20 @@ static struct commit_list *reduce_parents(struct commit *head_commit,
10761076
return remoteheads;
10771077
}
10781078

1079+
static void prepare_merge_message(struct strbuf *merge_names, struct strbuf *merge_msg)
1080+
{
1081+
struct fmt_merge_msg_opts opts;
1082+
1083+
memset(&opts, 0, sizeof(opts));
1084+
opts.add_title = !have_message;
1085+
opts.shortlog_len = shortlog_len;
1086+
opts.credit_people = (0 < option_edit);
1087+
1088+
fmt_merge_msg(merge_names, merge_msg, &opts);
1089+
if (merge_msg->len)
1090+
strbuf_setlen(merge_msg, merge_msg->len - 1);
1091+
}
1092+
10791093
static struct commit_list *collect_parents(struct commit *head_commit,
10801094
int *head_subsumed,
10811095
int argc, const char **argv)
@@ -1248,20 +1262,10 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
12481262

12491263
if (!have_message || shortlog_len) {
12501264
struct strbuf merge_names = STRBUF_INIT;
1251-
struct fmt_merge_msg_opts opts;
12521265

12531266
for (p = remoteheads; p; p = p->next)
12541267
merge_name(merge_remote_util(p->item)->name, &merge_names);
1255-
1256-
memset(&opts, 0, sizeof(opts));
1257-
opts.add_title = !have_message;
1258-
opts.shortlog_len = shortlog_len;
1259-
opts.credit_people = (0 < option_edit);
1260-
1261-
fmt_merge_msg(&merge_names, &merge_msg, &opts);
1262-
if (merge_msg.len)
1263-
strbuf_setlen(&merge_msg, merge_msg.len - 1);
1264-
1268+
prepare_merge_message(&merge_names, &merge_msg);
12651269
strbuf_release(&merge_names);
12661270
}
12671271
}

0 commit comments

Comments
 (0)