Skip to content

Commit 5500834

Browse files
dschoGit for Windows Build Agent
dscho
authored and
Git for Windows Build Agent
committed
Merge pull request #2618 from dscho/avoid-d/f-conflict-in-vs/master
ci: avoid d/f conflict in vs/master
2 parents ef94ef8 + 1291ea2 commit 5500834

File tree

4 files changed

+28
-26
lines changed

4 files changed

+28
-26
lines changed

‎config.mak.uname

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,7 @@ vcxproj:
749749

750750
# Make .vcxproj files and add them
751751
perl contrib/buildsystems/generate -g Vcxproj
752-
git add -f git.sln {*,*/lib,t/helper/*}/*.vcxproj
752+
git add -f git.sln {*,*/lib.proj,t/helper/*}/*.vcxproj
753753

754754
# Generate the LinkOrCopyBuiltins.targets and LinkOrCopyRemoteHttp.targets file
755755
(echo '<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">' && \
@@ -759,16 +759,16 @@ vcxproj:
759759
echo ' <Copy SourceFiles="$$(OutDir)\git.exe" DestinationFiles="$$(OutDir)\'"$$name"'" SkipUnchangedFiles="true" UseHardlinksIfPossible="true" />'; \
760760
done && \
761761
echo ' </Target>' && \
762-
echo '</Project>') >git/LinkOrCopyBuiltins.targets
762+
echo '</Project>') >git.proj/LinkOrCopyBuiltins.targets
763763
(echo '<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">' && \
764764
echo ' <Target Name="CopyBuiltins_AfterBuild" AfterTargets="AfterBuild">' && \
765765
for name in $(REMOTE_CURL_ALIASES); \
766766
do \
767767
echo ' <Copy SourceFiles="$$(OutDir)\'"$(REMOTE_CURL_PRIMARY)"'" DestinationFiles="$$(OutDir)\'"$$name"'" SkipUnchangedFiles="true" UseHardlinksIfPossible="true" />'; \
768768
done && \
769769
echo ' </Target>' && \
770-
echo '</Project>') >git-remote-http/LinkOrCopyRemoteHttp.targets
771-
git add -f git/LinkOrCopyBuiltins.targets git-remote-http/LinkOrCopyRemoteHttp.targets
770+
echo '</Project>') >git-remote-http.proj/LinkOrCopyRemoteHttp.targets
771+
git add -f git.proj/LinkOrCopyBuiltins.targets git-remote-http.proj/LinkOrCopyRemoteHttp.targets
772772

773773
# Add generated headers
774774
$(MAKE) MSVC=1 SKIP_VCPKG=1 prefix=/mingw64 $(GENERATED_H)

‎contrib/buildsystems/Generators/Vcxproj.pm

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ sub createProject {
5858
my $uuid = generate_guid($name);
5959
$$build_structure{"$prefix${target}_GUID"} = $uuid;
6060
my $vcxproj = $target;
61-
$vcxproj =~ s/(.*\/)?(.*)/$&\/$2.vcxproj/;
62-
$vcxproj =~ s/([^\/]*)(\/lib)\/(lib.vcxproj)/$1$2\/$1_$3/;
61+
$vcxproj =~ s/(.*\/)?(.*)/$&.proj\/$2.vcxproj/;
62+
$vcxproj =~ s/([^\/]*)(\/lib\.proj)\/(lib.vcxproj)/$1$2\/$1_$3/;
6363
$$build_structure{"$prefix${target}_VCXPROJ"} = $vcxproj;
6464

6565
my @srcs = sort(map("$rel_dir\\$_", @{$$build_structure{"$prefix${name}_SOURCES"}}));
@@ -89,7 +89,9 @@ sub createProject {
8989
$defines =~ s/>/&gt;/g;
9090
$defines =~ s/\'//g;
9191

92-
die "Could not create the directory $target for $label project!\n" unless (-d "$target" || mkdir "$target");
92+
my $dir = $vcxproj;
93+
$dir =~ s/\/[^\/]*$//;
94+
die "Could not create the directory $dir for $label project!\n" unless (-d "$dir" || mkdir "$dir");
9395

9496
open F, ">$vcxproj" or die "Could not open $vcxproj for writing!\n";
9597
binmode F, ":crlf :utf8";
@@ -237,7 +239,7 @@ EOM
237239

238240
print F << "EOM";
239241
<ItemGroup>
240-
<ProjectReference Include="$cdup\\libgit\\libgit.vcxproj">
242+
<ProjectReference Include="$cdup\\libgit.proj\\libgit.vcxproj">
241243
<Project>$uuid_libgit</Project>
242244
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
243245
</ProjectReference>
@@ -252,7 +254,7 @@ EOM
252254
}
253255
if (!($name =~ 'xdiff')) {
254256
print F << "EOM";
255-
<ProjectReference Include="$cdup\\xdiff\\lib\\xdiff_lib.vcxproj">
257+
<ProjectReference Include="$cdup\\xdiff\\lib.proj\\xdiff_lib.vcxproj">
256258
<Project>$uuid_xdiff_lib</Project>
257259
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
258260
</ProjectReference>
@@ -261,7 +263,7 @@ EOM
261263
if ($name =~ /(test-(line-buffer|svn-fe)|^git-remote-testsvn)\.exe$/) {
262264
my $uuid_vcs_svn_lib = $$build_structure{"LIBS_vcs-svn/lib_GUID"};
263265
print F << "EOM";
264-
<ProjectReference Include="$cdup\\vcs-svn\\lib\\vcs-svn_lib.vcxproj">
266+
<ProjectReference Include="$cdup\\vcs-svn\\lib.proj\\vcs-svn_lib.vcxproj">
265267
<Project>$uuid_vcs_svn_lib</Project>
266268
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
267269
</ProjectReference>
@@ -338,7 +340,7 @@ sub createGlueProject {
338340
my $vcxproj = $build_structure{"APPS_${appname}_VCXPROJ"};
339341
$vcxproj =~ s/\//\\/g;
340342
$appname =~ s/.*\///;
341-
print F "\"${appname}\", \"${vcxproj}\", \"${uuid}\"";
343+
print F "\"${appname}.proj\", \"${vcxproj}\", \"${uuid}\"";
342344
print F "$SLN_POST";
343345
}
344346
foreach (@libs) {
@@ -348,7 +350,7 @@ sub createGlueProject {
348350
my $vcxproj = $build_structure{"LIBS_${libname}_VCXPROJ"};
349351
$vcxproj =~ s/\//\\/g;
350352
$libname =~ s/\//_/g;
351-
print F "\"${libname}\", \"${vcxproj}\", \"${uuid}\"";
353+
print F "\"${libname}.proj\", \"${vcxproj}\", \"${uuid}\"";
352354
print F "$SLN_POST";
353355
}
354356

‎t/t5505-remote.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -835,8 +835,8 @@ test_expect_success '"remote show" does not show symbolic refs' '
835835
(
836836
cd three &&
837837
git remote show origin >output &&
838-
! grep "^ *HEAD$" < output &&
839-
! grep -i stale < output
838+
! grep "^ *HEAD$" <output &&
839+
! grep -i stale <output
840840
)
841841
'
842842

@@ -1039,7 +1039,7 @@ test_expect_success 'migrate a remote from named file in $GIT_DIR/branches' '
10391039
(
10401040
cd six &&
10411041
git remote rm origin &&
1042-
mkdir .git/branches &&
1042+
mkdir -p .git/branches &&
10431043
echo "$origin_url#main" >.git/branches/origin &&
10441044
git remote rename origin origin &&
10451045
test_path_is_missing .git/branches/origin &&
@@ -1054,8 +1054,8 @@ test_expect_success 'migrate a remote from named file in $GIT_DIR/branches (2)'
10541054
(
10551055
cd seven &&
10561056
git remote rm origin &&
1057-
mkdir .git/branches &&
1058-
echo "quux#foom" > .git/branches/origin &&
1057+
mkdir -p .git/branches &&
1058+
echo "quux#foom" >.git/branches/origin &&
10591059
git remote rename origin origin &&
10601060
test_path_is_missing .git/branches/origin &&
10611061
test "$(git config remote.origin.url)" = "quux" &&

‎t/t5516-fetch-push.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -958,8 +958,8 @@ test_expect_success 'fetch with branches' '
958958
mk_empty testrepo &&
959959
git branch second $the_first_commit &&
960960
git checkout second &&
961-
mkdir testrepo/.git/branches &&
962-
echo ".." > testrepo/.git/branches/branch1 &&
961+
mkdir -p testrepo/.git/branches &&
962+
echo ".." >testrepo/.git/branches/branch1 &&
963963
(
964964
cd testrepo &&
965965
git fetch branch1 &&
@@ -972,8 +972,8 @@ test_expect_success 'fetch with branches' '
972972

973973
test_expect_success 'fetch with branches containing #' '
974974
mk_empty testrepo &&
975-
mkdir testrepo/.git/branches &&
976-
echo "..#second" > testrepo/.git/branches/branch2 &&
975+
mkdir -p testrepo/.git/branches &&
976+
echo "..#second" >testrepo/.git/branches/branch2 &&
977977
(
978978
cd testrepo &&
979979
git fetch branch2 &&
@@ -989,8 +989,8 @@ test_expect_success 'push with branches' '
989989
git checkout second &&
990990
991991
test_when_finished "rm -rf .git/branches" &&
992-
mkdir .git/branches &&
993-
echo "testrepo" > .git/branches/branch1 &&
992+
mkdir -p .git/branches &&
993+
echo "testrepo" >.git/branches/branch1 &&
994994
995995
git push branch1 &&
996996
(
@@ -1005,8 +1005,8 @@ test_expect_success 'push with branches containing #' '
10051005
mk_empty testrepo &&
10061006
10071007
test_when_finished "rm -rf .git/branches" &&
1008-
mkdir .git/branches &&
1009-
echo "testrepo#branch3" > .git/branches/branch2 &&
1008+
mkdir -p .git/branches &&
1009+
echo "testrepo#branch3" >.git/branches/branch2 &&
10101010
10111011
git push branch2 &&
10121012
(
@@ -1535,7 +1535,7 @@ EOF
15351535
git init no-thin &&
15361536
git --git-dir=no-thin/.git config receive.unpacklimit 0 &&
15371537
git push no-thin/.git refs/heads/main:refs/heads/foo &&
1538-
echo modified >> path1 &&
1538+
echo modified >>path1 &&
15391539
git commit -am modified &&
15401540
git repack -adf &&
15411541
rcvpck="git receive-pack --reject-thin-pack-for-testing" &&

0 commit comments

Comments
 (0)