Skip to content

Commit 56bc729

Browse files
nalladscho
authored andcommitted
mingw: explicitly fflush stdout
For performance reasons `stdout` is not unbuffered by default. That leads to problems if after printing to `stdout` a read on `stdin` is performed. For that reason interactive commands like `git clean -i` do not function properly anymore if the `stdout` is not flushed by `fflush(stdout)` before trying to read from `stdin`. In the case of `git clean -i` all reads on `stdin` were preceded by a `fflush(stdout)` call. Signed-off-by: nalla <[email protected]>
1 parent 8aa6e42 commit 56bc729

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

builtin/clean.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -594,6 +594,7 @@ static int *list_and_choose(struct menu_opts *opts, struct menu_stuff *stuff)
594594
clean_get_color(CLEAN_COLOR_RESET));
595595
}
596596

597+
fflush(stdout);
597598
if (strbuf_getline(&choice, stdin, '\n') != EOF) {
598599
strbuf_trim(&choice);
599600
} else {
@@ -676,6 +677,7 @@ static int filter_by_patterns_cmd(void)
676677
clean_print_color(CLEAN_COLOR_PROMPT);
677678
printf(_("Input ignore patterns>> "));
678679
clean_print_color(CLEAN_COLOR_RESET);
680+
fflush(stdout);
679681
if (strbuf_getline(&confirm, stdin, '\n') != EOF)
680682
strbuf_trim(&confirm);
681683
else
@@ -774,6 +776,7 @@ static int ask_each_cmd(void)
774776
qname = quote_path_relative(item->string, NULL, &buf);
775777
/* TRANSLATORS: Make sure to keep [y/N] as is */
776778
printf(_("Remove %s [y/N]? "), qname);
779+
fflush(stdout);
777780
if (strbuf_getline(&confirm, stdin, '\n') != EOF) {
778781
strbuf_trim(&confirm);
779782
} else {

0 commit comments

Comments
 (0)