Skip to content

Commit 5fbd208

Browse files
kbleesGit for Windows Build Agent
authored andcommitted
Win32: make the lstat implementation pluggable
Emulating the POSIX lstat API on Windows via GetFileAttributes[Ex] is quite slow. Windows operating system APIs seem to be much better at scanning the status of entire directories than checking single files. A caching implementation may improve performance by bulk-reading entire directories or reusing data obtained via opendir / readdir. Make the lstat implementation pluggable so that it can be switched at runtime, e.g. based on a config option. Signed-off-by: Karsten Blees <[email protected]>
1 parent 408a0a6 commit 5fbd208

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

compat/mingw.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -680,6 +680,8 @@ static int do_stat_internal(int follow, const char *file_name, struct stat *buf)
680680
return do_lstat(follow, alt_name, buf);
681681
}
682682

683+
int (*lstat)(const char *file_name, struct stat *buf) = mingw_lstat;
684+
683685
int mingw_lstat(const char *file_name, struct stat *buf)
684686
{
685687
return do_stat_internal(0, file_name, buf);

compat/mingw.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ int mingw_fstat(int fd, struct stat *buf);
368368
#ifdef lstat
369369
#undef lstat
370370
#endif
371-
#define lstat mingw_lstat
371+
extern int (*lstat)(const char *file_name, struct stat *buf);
372372

373373
#ifndef _stati64
374374
# define _stati64(x,y) mingw_stat(x,y)

0 commit comments

Comments
 (0)