Skip to content

Commit 5fd7227

Browse files
committed
Merge branch 'jk/make-fix-dependencies' into maint
Build clean-up. * jk/make-fix-dependencies: Makefile: silence perl/PM.stamp recipe Makefile: avoid timestamp updates to GIT-BUILD-OPTIONS Makefile: drop dependency between git-instaweb and gitweb
2 parents 68538cf + 7c37a5d commit 5fd7227

File tree

1 file changed

+25
-24
lines changed

1 file changed

+25
-24
lines changed

Makefile

Lines changed: 25 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1740,7 +1740,7 @@ $(SCRIPT_PERL_GEN): perl/perl.mak
17401740
perl/perl.mak: perl/PM.stamp
17411741

17421742
perl/PM.stamp: FORCE
1743-
$(QUIET_GEN)$(FIND) perl -type f -name '*.pm' | sort >$@+ && \
1743+
@$(FIND) perl -type f -name '*.pm' | sort >$@+ && \
17441744
{ cmp $@+ $@ >/dev/null 2>/dev/null || mv $@+ $@; } && \
17451745
$(RM) $@+
17461746

@@ -1777,7 +1777,7 @@ GIT-PERL-DEFINES: FORCE
17771777
gitweb:
17781778
$(QUIET_SUBDIR0)gitweb $(QUIET_SUBDIR1) all
17791779

1780-
git-instaweb: git-instaweb.sh gitweb GIT-SCRIPT-DEFINES
1780+
git-instaweb: git-instaweb.sh GIT-SCRIPT-DEFINES
17811781
$(QUIET_GEN)$(cmd_munge_script) && \
17821782
chmod +x $@+ && \
17831783
mv $@+ $@
@@ -2096,46 +2096,47 @@ GIT-LDFLAGS: FORCE
20962096
# that runs GIT-BUILD-OPTIONS, and then again to protect it
20972097
# and the first level quoting from the shell that runs "echo".
20982098
GIT-BUILD-OPTIONS: FORCE
2099-
@echo SHELL_PATH=\''$(subst ','\'',$(SHELL_PATH_SQ))'\' >$@
2100-
@echo PERL_PATH=\''$(subst ','\'',$(PERL_PATH_SQ))'\' >>$@
2101-
@echo DIFF=\''$(subst ','\'',$(subst ','\'',$(DIFF)))'\' >>$@
2102-
@echo PYTHON_PATH=\''$(subst ','\'',$(PYTHON_PATH_SQ))'\' >>$@
2103-
@echo TAR=\''$(subst ','\'',$(subst ','\'',$(TAR)))'\' >>$@
2104-
@echo NO_CURL=\''$(subst ','\'',$(subst ','\'',$(NO_CURL)))'\' >>$@
2105-
@echo NO_EXPAT=\''$(subst ','\'',$(subst ','\'',$(NO_EXPAT)))'\' >>$@
2106-
@echo USE_LIBPCRE=\''$(subst ','\'',$(subst ','\'',$(USE_LIBPCRE)))'\' >>$@
2107-
@echo NO_PERL=\''$(subst ','\'',$(subst ','\'',$(NO_PERL)))'\' >>$@
2108-
@echo NO_PYTHON=\''$(subst ','\'',$(subst ','\'',$(NO_PYTHON)))'\' >>$@
2109-
@echo NO_UNIX_SOCKETS=\''$(subst ','\'',$(subst ','\'',$(NO_UNIX_SOCKETS)))'\' >>$@
2099+
@echo SHELL_PATH=\''$(subst ','\'',$(SHELL_PATH_SQ))'\' >$@+
2100+
@echo PERL_PATH=\''$(subst ','\'',$(PERL_PATH_SQ))'\' >>$@+
2101+
@echo DIFF=\''$(subst ','\'',$(subst ','\'',$(DIFF)))'\' >>$@+
2102+
@echo PYTHON_PATH=\''$(subst ','\'',$(PYTHON_PATH_SQ))'\' >>$@+
2103+
@echo TAR=\''$(subst ','\'',$(subst ','\'',$(TAR)))'\' >>$@+
2104+
@echo NO_CURL=\''$(subst ','\'',$(subst ','\'',$(NO_CURL)))'\' >>$@+
2105+
@echo NO_EXPAT=\''$(subst ','\'',$(subst ','\'',$(NO_EXPAT)))'\' >>$@+
2106+
@echo USE_LIBPCRE=\''$(subst ','\'',$(subst ','\'',$(USE_LIBPCRE)))'\' >>$@+
2107+
@echo NO_PERL=\''$(subst ','\'',$(subst ','\'',$(NO_PERL)))'\' >>$@+
2108+
@echo NO_PYTHON=\''$(subst ','\'',$(subst ','\'',$(NO_PYTHON)))'\' >>$@+
2109+
@echo NO_UNIX_SOCKETS=\''$(subst ','\'',$(subst ','\'',$(NO_UNIX_SOCKETS)))'\' >>$@+
21102110
ifdef TEST_OUTPUT_DIRECTORY
2111-
@echo TEST_OUTPUT_DIRECTORY=\''$(subst ','\'',$(subst ','\'',$(TEST_OUTPUT_DIRECTORY)))'\' >>$@
2111+
@echo TEST_OUTPUT_DIRECTORY=\''$(subst ','\'',$(subst ','\'',$(TEST_OUTPUT_DIRECTORY)))'\' >>$@+
21122112
endif
21132113
ifdef GIT_TEST_OPTS
2114-
@echo GIT_TEST_OPTS=\''$(subst ','\'',$(subst ','\'',$(GIT_TEST_OPTS)))'\' >>$@
2114+
@echo GIT_TEST_OPTS=\''$(subst ','\'',$(subst ','\'',$(GIT_TEST_OPTS)))'\' >>$@+
21152115
endif
21162116
ifdef GIT_TEST_CMP
2117-
@echo GIT_TEST_CMP=\''$(subst ','\'',$(subst ','\'',$(GIT_TEST_CMP)))'\' >>$@
2117+
@echo GIT_TEST_CMP=\''$(subst ','\'',$(subst ','\'',$(GIT_TEST_CMP)))'\' >>$@+
21182118
endif
21192119
ifdef GIT_TEST_CMP_USE_COPIED_CONTEXT
2120-
@echo GIT_TEST_CMP_USE_COPIED_CONTEXT=YesPlease >>$@
2120+
@echo GIT_TEST_CMP_USE_COPIED_CONTEXT=YesPlease >>$@+
21212121
endif
2122-
@echo NO_GETTEXT=\''$(subst ','\'',$(subst ','\'',$(NO_GETTEXT)))'\' >>$@
2123-
@echo GETTEXT_POISON=\''$(subst ','\'',$(subst ','\'',$(GETTEXT_POISON)))'\' >>$@
2122+
@echo NO_GETTEXT=\''$(subst ','\'',$(subst ','\'',$(NO_GETTEXT)))'\' >>$@+
2123+
@echo GETTEXT_POISON=\''$(subst ','\'',$(subst ','\'',$(GETTEXT_POISON)))'\' >>$@+
21242124
ifdef GIT_PERF_REPEAT_COUNT
2125-
@echo GIT_PERF_REPEAT_COUNT=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_REPEAT_COUNT)))'\' >>$@
2125+
@echo GIT_PERF_REPEAT_COUNT=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_REPEAT_COUNT)))'\' >>$@+
21262126
endif
21272127
ifdef GIT_PERF_REPO
2128-
@echo GIT_PERF_REPO=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_REPO)))'\' >>$@
2128+
@echo GIT_PERF_REPO=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_REPO)))'\' >>$@+
21292129
endif
21302130
ifdef GIT_PERF_LARGE_REPO
2131-
@echo GIT_PERF_LARGE_REPO=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_LARGE_REPO)))'\' >>$@
2131+
@echo GIT_PERF_LARGE_REPO=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_LARGE_REPO)))'\' >>$@+
21322132
endif
21332133
ifdef GIT_PERF_MAKE_OPTS
2134-
@echo GIT_PERF_MAKE_OPTS=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_MAKE_OPTS)))'\' >>$@
2134+
@echo GIT_PERF_MAKE_OPTS=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_MAKE_OPTS)))'\' >>$@+
21352135
endif
21362136
ifdef TEST_GIT_INDEX_VERSION
2137-
@echo TEST_GIT_INDEX_VERSION=\''$(subst ','\'',$(subst ','\'',$(TEST_GIT_INDEX_VERSION)))'\' >>$@
2137+
@echo TEST_GIT_INDEX_VERSION=\''$(subst ','\'',$(subst ','\'',$(TEST_GIT_INDEX_VERSION)))'\' >>$@+
21382138
endif
2139+
@if cmp $@+ $@ >/dev/null 2>&1; then $(RM) $@+; else mv $@+ $@; fi
21392140

21402141
### Detect Python interpreter path changes
21412142
ifndef NO_PYTHON

0 commit comments

Comments
 (0)