Skip to content

Commit 647edf7

Browse files
peffgitster
authored andcommitted
http: drop unused parameter from start_object_request()
We take a "walker" parameter for the request, but don't actually look at it. This is due to 5424bc5 (http*: add helper methods for fetching objects (loose), 2009-06-06). Before then, we consulted the "walker" struct to tell us if we should be verbose, but now those messages are printed elsewhere. Let's drop the unused parameter to make -Wunused-parameter happy. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 910d07a commit 647edf7

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

http-walker.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ static void fetch_alternates(struct walker *walker, const char *base);
5353

5454
static void process_object_response(void *callback_data);
5555

56-
static void start_object_request(struct walker *walker,
57-
struct object_request *obj_req)
56+
static void start_object_request(struct object_request *obj_req)
5857
{
5958
struct active_request_slot *slot;
6059
struct http_object_request *req;
@@ -111,7 +110,7 @@ static void process_object_response(void *callback_data)
111110
obj_req->repo =
112111
obj_req->repo->next;
113112
release_http_object_request(obj_req->req);
114-
start_object_request(walker, obj_req);
113+
start_object_request(obj_req);
115114
return;
116115
}
117116
}
@@ -139,7 +138,7 @@ static int fill_active_slot(struct walker *walker)
139138
if (has_object_file(&obj_req->oid))
140139
obj_req->state = COMPLETE;
141140
else {
142-
start_object_request(walker, obj_req);
141+
start_object_request(obj_req);
143142
return 1;
144143
}
145144
}

0 commit comments

Comments
 (0)