Skip to content

Commit 69b050e

Browse files
committed
Merge branch 'jk/alternate-ref-optim'
A test allowed both "git push" and "git receive-pack" on the other end write their traces into the same file. This is OK on platforms that allows atomically appending to a file opened with O_APPEND, but on other platforms led to a mangled output, causing intermittent test failures. This has been fixed by disabling traces from "receive-pack" in the test. * jk/alternate-ref-optim: t5400: avoid concurrent writes into a trace file
2 parents 965993d + 71406ed commit 69b050e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

t/t5400-send-pack.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,10 @@ test_expect_success 'receive-pack de-dupes .have lines' '
288288
$shared .have
289289
EOF
290290
291-
GIT_TRACE_PACKET=$(pwd)/trace git push fork HEAD:foo &&
291+
GIT_TRACE_PACKET=$(pwd)/trace \
292+
git push \
293+
--receive-pack="unset GIT_TRACE_PACKET; git-receive-pack" \
294+
fork HEAD:foo &&
292295
extract_ref_advertisement <trace >refs &&
293296
test_cmp expect refs
294297
'

0 commit comments

Comments
 (0)